Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate # fn in docs #21050

Closed
wants to merge 1 commit into from
Closed

Conversation

steveklabnik
Copy link
Member

I searched for times when we were hiding functions with # in the documentation,
and fixed them to not use it unless neccesary.

I also made random improvements whenever I changed something. For example,
I changed Example to Examples, for consistency.

Fixes #13423

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

let (tx, rx) = channel();
# use std::sync::mpsc;
# fn some_expensive_computation() -> u32 { 42 }

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this line will appear in the output; might be better to just remove it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

I searched for times when we were hiding functions with # in the documentation,
and fixed them to not use it unless neccesary.

I also made random improvements whenever I changed something. For example,
I changed Example to Examples, for consistency.

Fixes rust-lang#13423
bors added a commit that referenced this pull request Jan 17, 2015
Evaluate # fn in docs

Reviewed-by: nikomatsakis
bors added a commit that referenced this pull request Jan 17, 2015
Evaluate # fn in docs

Reviewed-by: nikomatsakis
@steveklabnik
Copy link
Member Author

doing this manually in #21300

@steveklabnik steveklabnik deleted the gh13423 branch October 25, 2017 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write (at least) type signatures of placeholder functions in docs
5 participants