Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert stability for Bitv and BitvSet #21208

Closed
wants to merge 1 commit into from

Conversation

nagisa
Copy link
Member

@nagisa nagisa commented Jan 15, 2015

The collections were promoted to stable by mistake and do not match RFC 509.
This reverts the stability back to unstable.

[breaking-change] since previously stable API became unstable.

Fixes #21193

r? @gankro

@Gankra
Copy link
Contributor

Gankra commented Jan 15, 2015

I'm not great at how the stability attributes work, but I believe it's fine to stabilize the methods, just not the type itself. Basically stating that "I dunno if we're gonna have this type, but if we do, it'll look like this".

@Gankra
Copy link
Contributor

Gankra commented Jan 15, 2015

r? @aturon

@rust-highfive rust-highfive assigned aturon and unassigned Gankra Jan 15, 2015
@aturon
Copy link
Member

aturon commented Jan 15, 2015

@gankro

I'm not great at how the stability attributes work, but I believe it's fine to stabilize the methods, just not the type itself. Basically stating that "I dunno if we're gonna have this type, but if we do, it'll look like this".

Yes, exactly. This PR should revert only the types and modules.

@nagisa
Copy link
Member Author

nagisa commented Jan 15, 2015

Will do tomorrow.

The collections were promoted to stable by mistake and do not match RFC 509.
This reverts the stability back to unstable.

[breaking-change] since previously stable API became unstable.

Fixes rust-lang#21193
@nagisa
Copy link
Member Author

nagisa commented Jan 16, 2015

Only Bitv and BitvSet structs and collections::{bitv,bitv_set} are unstable now.

@aturon
Copy link
Member

aturon commented Jan 16, 2015

@nagisa Thanks! But would you mind also reverting the modules std::collections::bitv and bitv_set to unstable as well?

@nagisa
Copy link
Member Author

nagisa commented Jan 16, 2015

Ah, must have forgoten to push that, done.

bors added a commit that referenced this pull request Jan 17, 2015
Revert stability for Bitv and BitvSet

Reviewed-by: aturon, aturon
bors added a commit that referenced this pull request Jan 17, 2015
Revert stability for Bitv and BitvSet

Reviewed-by: aturon, aturon
@steveklabnik
Copy link
Member

Doing this manually as part of #21300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bitv/BitvSet's #[stable] mismatches collections reform RFC
4 participants