Add std::process #22119
Add std::process #22119
Conversation
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
This is WIP for two reasons:
|
aturon
force-pushed
the
new-process
branch
2 times, most recently
from
30d9074
to
2ffc70f
Compare
aturon
force-pushed
the
new-process
branch
3 times, most recently
from
b96a50b
to
f994b8f
Compare
| #[cfg(windows)] const MustDieSignal: int = 9; | ||
| /// Signal a process to exit immediately, forcibly killing it. Corresponds to | ||
| /// SIGKILL on unix platforms. | ||
| #[cfg(not(windows))] const MustDieSignal: int = libc::SIGKILL as int; |
There was a problem hiding this comment.
I think that in general we've had pretty good success with trying to have as few #[cfg] directives as possible, could this logic be pushed into each respective sys module?
There was a problem hiding this comment.
This should probably not be an int.
|
💔 Test failed - auto-win-32-nopt-t |
|
💔 Test failed - auto-win-64-opt |
|
@bors: retry |
|
⌛ Testing commit 1a72dac with merge d05755d... |
|
💔 Test failed - auto-win-32-opt |
aturon
force-pushed
the
new-process
branch
3 times, most recently
from
9c50a35
to
0f697c2
Compare
|
@bors: r=alexcrichton 0f697c2 p=1 |
|
⌛ Testing commit 0f697c2 with merge 1ac4113... |
|
💔 Test failed - auto-win-32-nopt-t |
|
@bors: r=alexcrichton bec4af2 p=1 |
|
⌛ Testing commit bec4af2 with merge 972bafc... |
|
💔 Test failed - auto-linux-64-x-android-t |
Per [RFC 579](rust-lang/rfcs#579), this commit adds a new `std::process` module. This module is largely based on the existing `std::old_io::process` module, but refactors the API to use `OsStr` and other new standards set out by IO reform. The existing module is not yet deprecated, to allow for the new API to get a bit of testing before a mass migration to it.
Per [RFC 579](rust-lang/rfcs#579), this commit adds a new `std::process` module. This module is largely based on the existing `std::old_io::process` module, but refactors the API to use `OsStr` and other new standards set out by IO reform. The existing module is not yet deprecated, to allow for the new API to get a bit of testing before a mass migration to it.
Per RFC 579, this commit
adds a new
std::processmodule. This module is largely based on theexisting
std::old_io::processmodule, but refactors the API to useOsStrand other new standards set out by IO reform.The existing module is not yet deprecated, to allow for the new API to
get a bit of testing before a mass migration to it.