Feature gate box patterns
#22175
Merged
Feature gate box patterns
#22175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch feature-gate checker from `box_syntax` to `box_patterns` when visiting a pattern. (Having to opt into both `box_syntax` and `box_patterns` seemed unnecessary.) [breaking-change]
Namely: `collections` (used in `dlist.rs`), `syntax`, `rustc`, `rustc_typeck`, `rustc_trans`, and `rustdoc`.
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
r+ but let's change the wording to "experimental" not "experimental in alpha release" |
|
⌛ Testing commit dbe0828 with merge ff49986... |
|
💔 Test failed - auto-mac-64-opt |
|
what the heck? That test passed when I |
|
argh! Its because i changed the error message! |
just say "experimental."
bors
added a commit
that referenced
this pull request
Feb 11, 2015
…akis Feature gate `box` patterns. Note that this adds a new feature gate, `box_patterns` specific to e.g. `let box i = ...`, while leaving `box` expressions (alone) still guarded via the preexisting `box_syntax`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature gate
boxpatterns.Note that this adds a new feature gate,
box_patternsspecific to e.g.let box i = ..., while leavingboxexpressions (alone) still guarded via the preexistingbox_syntax.Fix #21931