core: Audit num module for int/uint #22600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 tasks
| from_str_radix_int_impl! { i8 } | ||
| from_str_radix_int_impl! { i16 } | ||
| from_str_radix_int_impl! { i32 } | ||
| from_str_radix_int_impl! { i64 } | ||
| from_str_radix_int_impl! { uint } |
There was a problem hiding this comment.
Won't this cause a hard disappearance (in contrast to your other changes)?
There was a problem hiding this comment.
I think not, but am not sure. Isn't an impl for usize also an impl for uint?
|
@bors r+ dce44 |
|
Have a great day ☀️ |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 21, 2015
* count_ones/zeros, trailing_ones/zeros return u32, not usize * rotate_left/right take u32, not usize * RADIX, MANTISSA_DIGITS, DIGITS, BITS, BYTES are u32, not usize Doesn't touch pow because there's another PR for it. cc rust-lang#22240 r? @gankro
|
(needs rebase) |
|
cc #22240 |
* count_ones/zeros, trailing_ones/zeros return u32, not usize * rotate_left/right take u32, not usize * RADIX, MANTISSA_DIGITS, DIGITS, BITS, BYTES are u32, not usize Doesn't touch pow because there's another PR for it. [breaking-change]
|
@bors: r=Gankro 76e9 |
apasel422
added a commit
to contain-rs/trie
that referenced
this pull request
Mar 15, 2015
closes #134
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't touch pow because there's another PR for it.
cc #22240
r? @gankro