-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std: Stabilize the process
module
#22882
Conversation
r? @aturon |
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
I will point out that the only grievance I've found in migrating to cmd.stdin(Stdio::capture()) In one sense we're not really "capturing stdin" we're more "creating a pipe for it", but I also do not feel strongly about this and can be led to believe that we are indeed "capturing stdin to a pipe". |
3cfafa8
to
9495db7
Compare
I would be happy for r=me after a rename. |
How about |
|
9495db7
to
3c7937c
Compare
@bors: r=aturon 3c7937c |
This fails tidy, apparently you cannot have a feature used for both stable and unstable things |
@bors: r- |
3c7937c
to
97dbf86
Compare
@bors: r=aturon 97dbf86 |
⌛ Testing commit 97dbf86 with merge e2b47a4... |
⌛ Testing commit 97dbf86 with merge 83a0c4a... |
💔 Test failed - auto-linux-64-opt |
This commits blanket marks the API of the `std::process` module as `#[stable]`. The module's API is very similar to the old `std::old_io::process` API and has generally had quite a bit of time to bake both before and after the new module landed. The one modification made to the API is that `Stdio::capture` is now named `stdio::piped`. [breaking-change]
97dbf86
to
93613a5
Compare
This commits blanket marks the API of the `std::process` module as `#[stable]`. The module's API is very similar to the old `std::old_io::process` API and has generally had quite a bit of time to bake both before and after the new module landed.
💔 Test failed - auto-win-32-opt |
@bors: retry |
(Timeout; probably not caused by this) |
⌛ Testing commit 93613a5 with merge b4c965e... |
This commits blanket marks the API of the `std::process` module as `#[stable]`. The module's API is very similar to the old `std::old_io::process` API and has generally had quite a bit of time to bake both before and after the new module landed.
This commits blanket marks the API of the
std::process
module as#[stable]
.The module's API is very similar to the old
std::old_io::process
API and hasgenerally had quite a bit of time to bake both before and after the new module
landed.