Unquote crate names #23777
Unquote crate names #23777
Conversation
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
|
Just noticed #23738 right on time :) |
|
@bors: r+ 70e61013b1fb0aa6208162efa0ffefa8a1a6ec55 |
| @@ -12,7 +12,7 @@ | |||
|
|
|||
| // pretty-expanded FIXME #23616 | |||
|
|
|||
| extern crate "xcrate-trait-lifetime-param" as other; | |||
| extern crate xcrate-trait-lifetime-param as other; | |||
There was a problem hiding this comment.
There are hyphens in unquoted crate names here and some other places.
|
@bors: r- I think @petrochenkov is right in that this won't land as-is. Can you also be sure to run all the tests as well? |
|
Sure, sorry I PR'd this and then went to bed. I wasn't expecting it to r+ until that snapshot landed. I'll poke today. |
|
I've also got a PR where I'm removing parser support, so I can try to just roll this into that as well. |
|
Reran the script to only unquote non-hyphenated crates. r? @alexcrichton (I think this still needs snaps to land, didn't see if they did) |
|
Thanks! I've rolled this into #23786 where I took care of the rest of the tests and also handled the compiler support. |
|
\o/ thanks |
I believe this needs a snapshot to land.