make clean deletes tmp, not tmp/*

[tbelaire]

This might fix bug #12966.
I haven't been able to reproduce it yet however, so I'm not sure if this fixes it.

I have checked, and the tmp directory is properly remade with a plain make call.

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

[alexcrichton]

I think this may actually break builds that run make check:

$ rm -rf tmp
$ make check
cfg: version 1.0.0-dev (0a3e700e3 2015-04-13) (built 2015-04-14)
cfg: build triple x86_64-unknown-linux-gnu
cfg: host triples x86_64-unknown-linux-gnu
cfg: target triples x86_64-unknown-linux-gnu
cfg: disabling rustc optimization (CFG_DISABLE_OPTIMIZE)
cfg: host for x86_64-unknown-linux-gnu is x86_64
cfg: os for x86_64-unknown-linux-gnu is unknown-linux-gnu
cfg: good valgrind for x86_64-unknown-linux-gnu is 1
cfg: using CC=ccache gcc (CFG_CC)
cfg: enabling valgrind run-pass tests (CFG_ENABLE_VALGRIND_RPASS)
cfg: valgrind-rpass command set to "/usr/bin/valgrind" --error-exitcode=100 --soname-synonyms=somalloc=NONE --quiet --suppressions=/home/alex/code/rust4/src/etc/x86.supp  --tool=memcheck --leak-check=full
cfg: no xelatex found, disabling LaTeX docs
cfg: no pandoc found, omitting PDF and EPUB docs
cfg: including test rules
cfg: javac not available, skipping lexer test...
cfg: flex not available, skipping parser test...
touch: cannot touch 'tmp/install-debugger-scripts1_H_x86_64-unknown-linux-gnu-gdb.done.start_time': No such file or directory
make: *** [tmp/install-debugger-scripts1_H_x86_64-unknown-linux-gnu-gdb.done] Error 1

[tbelaire]

Ah, thanks. I only tested a plain make. I'll see if I can fix that, and test the other make commands.

[lilyball]

Sounds like the mk/install-debugger-scripts* rules all need to have a order-only dependency on tmp/, which, if there's not already a rule for it, would need to make the tmp dir.

[tbelaire]

I'm not convinced this is worth working on right now, if I can't actually reproduce the bug I was trying to fix in the first place. I'm going to close this for now.