Clean up Box documentation. #24629
Merged
Clean up Box documentation. #24629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the `box` keyword, one of these two reasons is not correct, so let's just eliminate this section and elaborate on the reason for the legit use case inline. Fixes rust-lang#24511
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
| //! ``` | ||
| //! | ||
| //! It wouldn't work. This is because the size of a `List` depends on how many elements are in the | ||
| //! list, and so we don't know how much memory to allocate for a `Cons`. By introducing a `Box`, |
There was a problem hiding this comment.
This paragraph lacks curly apostrophes, if you still plan to use those throughout the documentation.
There was a problem hiding this comment.
Ah yes! Interesting, about my editor set up.
I think for now leaving these straight is fine. I've only been doing it in the book thus far, where imho it matters more.
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Apr 20, 2015
Without the `box` keyword, one of these two reasons is not correct, so let's just eliminate this section and elaborate on the reason for the legit use case inline. Fixes rust-lang#24511
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Apr 21, 2015
Without the `box` keyword, one of these two reasons is not correct, so let's just eliminate this section and elaborate on the reason for the legit use case inline. Fixes rust-lang#24511
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the
boxkeyword, one of these two reasons is not correct, solet's just eliminate this section and elaborate on the reason for the
legit use case inline.
Fixes #24511