Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update method-syntax.md #25214

Merged
merged 1 commit into from
May 9, 2015
Merged

Update method-syntax.md #25214

merged 1 commit into from
May 9, 2015

Conversation

acgtyrant
Copy link
Contributor

make the definition of static methods explicit

make the definition of static methods explicit
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@brson
Copy link
Contributor

brson commented May 8, 2015

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented May 8, 2015

📌 Commit 544362c has been approved by brson

@steveklabnik
Copy link
Member

These should actually be called 'associated functions' rather than static methods. I had thought I put a patch in fixing this...

@brson
Copy link
Contributor

brson commented May 8, 2015

@steveklabnik should we cancel this one?

@bors
Copy link
Contributor

bors commented May 9, 2015

⌛ Testing commit 544362c with merge 95400c5...

bors added a commit that referenced this pull request May 9, 2015
make the definition of static methods explicit
@bors bors merged commit 544362c into rust-lang:master May 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants