Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trpl: Use infinite iterator in chain example with take #25941

Merged
merged 1 commit into from
Jun 2, 2015

Conversation

puzza007
Copy link
Contributor

@puzza007 puzza007 commented Jun 1, 2015

No description provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@aochagavia
Copy link
Contributor

cc @steveklabnik

@steveklabnik
Copy link
Member

So, while it's true that you usually use unbounded iterators with take(), I'm not sure we actually explained them before this point. Can you look into that, please?

@steveklabnik steveklabnik assigned steveklabnik and unassigned pcwalton Jun 1, 2015
@puzza007
Copy link
Contributor Author

puzza007 commented Jun 1, 2015

Yeah they're explained in the previous section. https://github.com/rust-lang/rust/pull/25941/files#diff-f81dbe18693d6f4de2cd78b29a5ea670R284

@steveklabnik
Copy link
Member

@puzza007 excellent, thank you!

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Jun 1, 2015

📌 Commit 5fefae6 has been approved by steveklabnik

Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 2, 2015
bors added a commit that referenced this pull request Jun 2, 2015
@bors bors merged commit 5fefae6 into rust-lang:master Jun 2, 2015
@puzza007 puzza007 deleted the trpl-infinite-iterator-chain-take branch June 2, 2015 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants