Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc book improvements #25948

Merged
merged 3 commits into from
Jun 9, 2015
Merged

Misc book improvements #25948

merged 3 commits into from
Jun 9, 2015

Conversation

tshepang
Copy link
Member

@tshepang tshepang commented Jun 1, 2015

No description provided.

@rust-highfive
Copy link
Collaborator

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

@@ -33,8 +33,8 @@ let plus_two = |x| {
assert_eq!(4, plus_two(2));
```

You’ll notice a few things about closures that are a bit different than regular
functions defined with `fn`. The first of which is that we did not need to
You’ll notice a few things about closures that are a bit different to regular
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'to' reads very strangely to me. 'from' would sound good though. What do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed... done!

@steveklabnik
Copy link
Member

Looks great but one nit

@huonw huonw assigned steveklabnik and unassigned huonw Jun 2, 2015
@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Jun 8, 2015

📌 Commit 09c6203 has been approved by steveklabnik

Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 9, 2015
bors added a commit that referenced this pull request Jun 9, 2015
@bors bors merged commit 09c6203 into rust-lang:master Jun 9, 2015
@tshepang tshepang deleted the misc-doc-improvements branch June 18, 2015 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants