Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing #[inline] to methods related to char and fix related problem in String::push #26154

Merged
merged 2 commits into from
Jun 11, 2015

Conversation

pmarcelll
Copy link
Contributor

Various methods in both libcore/char.rs and librustc_unicode/char.rs were previously marked with #[inline], now every method is marked in char's impl blocks.
Partially fixes #26124.
EDIT: I'm not familiar with pull reqests (yet), apparently Github added my second commit to thit PR...
Fixes #26124

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@brson
Copy link
Contributor

brson commented Jun 9, 2015

@bors r+

@bors
Copy link
Contributor

bors commented Jun 9, 2015

📌 Commit c5d0e2a has been approved by brson

…character's UTF-8 representation is bigger than 1 byte
@pmarcelll pmarcelll changed the title Add missing #[inline] to methods related to char. Add missing #[inline] to methods related to char and fix related problem in String::push Jun 10, 2015
@pmarcelll
Copy link
Contributor Author

@SimonSapin, since you are the original author of the modified code, could you please look at the second commit to see if there's anything wrong with it? 😃

@Gankra
Copy link
Contributor

Gankra commented Jun 10, 2015

@bors r+

@bors
Copy link
Contributor

bors commented Jun 10, 2015

📌 Commit e87c62f has been approved by Gankro

@Gankra
Copy link
Contributor

Gankra commented Jun 10, 2015

Thanks!

@SimonSapin
Copy link
Contributor

@pmarcelll I am? Anyway, looks good to me.

@bors
Copy link
Contributor

bors commented Jun 10, 2015

⌛ Testing commit e87c62f with merge 34928d9...

@bors
Copy link
Contributor

bors commented Jun 10, 2015

💔 Test failed - auto-mac-64-nopt-t

@alexcrichton
Copy link
Member

@bors: retry

On Wed, Jun 10, 2015 at 7:08 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-mac-64-nopt-t
http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/5319


Reply to this email directly or view it on GitHub
#26154 (comment).

@bors
Copy link
Contributor

bors commented Jun 11, 2015

⌛ Testing commit e87c62f with merge 37cf025...

bors added a commit that referenced this pull request Jun 11, 2015
Various methods in both libcore/char.rs and librustc_unicode/char.rs were previously marked with #[inline], now every method is marked in char's impl blocks.
Partially fixes #26124.
EDIT: I'm not familiar with pull reqests (yet), apparently Github added my second commit to thit PR...
Fixes #26124
@bors bors merged commit e87c62f into rust-lang:master Jun 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

String::push reallocates too aggressively in corner cases
7 participants