Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std: Add FromRaw{Fd,Handle,Socket} to os preludes #26413

Merged
merged 1 commit into from
Jun 19, 2015
Merged

std: Add FromRaw{Fd,Handle,Socket} to os preludes #26413

merged 1 commit into from
Jun 19, 2015

Conversation

alexcrichton
Copy link
Member

These were just left out by mistake!

@alexcrichton
std: Add FromRaw{Fd,Handle,Socket} to os preludes
45f830b 
These were just left out by mistake!
@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@sfackler
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jun 18, 2015

📌 Commit 45f830b has been approved by sfackler

@alexcrichton
Copy link
Member Author

Nominating for beta backport as this is quite a nice-to-have

@alexcrichton alexcrichton added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 18, 2015
@alexcrichton
Copy link
Member Author

@bors: p=10 (b/c we're likely to backport)

@bors
Copy link
Contributor

bors commented Jun 18, 2015

⌛ Testing commit 45f830b with merge 2f56839...

bors added a commit that referenced this pull request Jun 18, 2015
@bors
Auto merge of #26413 - alexcrichton:from-raw-fd-prelude, r=sfackler
2f56839 
These were just left out by mistake!
@bors
Copy link
Contributor

bors commented Jun 19, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt

@bors bors merged commit 45f830b into rust-lang:master Jun 19, 2015
@alexcrichton
Copy link
Member Author

After some discussion, accepting for backport

@alexcrichton alexcrichton deleted the from-raw-fd-prelude branch June 19, 2015 18:22
@alexcrichton alexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jun 19, 2015
@brson brson mentioned this pull request Jun 19, 2015
Merged
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexcrichton @rust-highfive @sfackler @bors @aturon