-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename AsPredicate to ToPredicate in order to match naming conventions #26415
Conversation
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
r+ (but needs rebase) |
a1612f8
to
4f441f9
Compare
@bors r+ |
📌 Commit 4f441f9 has been approved by |
☔ The latest upstream changes (presumably #26351) made this pull request unmergeable. Please resolve the merge conflicts. |
4f441f9
to
af9e3b7
Compare
@bors r=nmatsakis |
📌 Commit af9e3b7 has been approved by |
⌛ Testing commit af9e3b7 with merge ac16fe3... |
💔 Test failed - auto-linux-64-nopt-t |
☔ The latest upstream changes (presumably #26435) made this pull request unmergeable. Please resolve the merge conflicts. |
af9e3b7
to
0914c52
Compare
@bors:r=nikomatsakis 0914c52 |
I'm sorry but I don't see any fix to address the error bors found for you:
|
☔ The latest upstream changes (presumably #26354) made this pull request unmergeable. Please resolve the merge conflicts. |
@bluss I built the wrong branch last night before pushing, should be fixed. |
0914c52
to
eab2895
Compare
@bors: r=nikomatsakis On Tue, Jun 23, 2015 at 8:49 AM Jared Roesch notifications@github.com
|
📌 Commit eab2895 has been approved by |
88631b3
to
8433801
Compare
8433801
to
44bccd8
Compare
@nikomatsakis and I ran into this earlier and I figured we should rename the trait and method to match the typical naming convention.
@nikomatsakis and I ran into this earlier and I figured we should rename the trait and method to match the typical naming convention.