Resolve lifetime parameters for foreign functions. #26588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Aatch (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -151,6 +151,29 @@ impl<'a, 'v> Visitor<'v> for LifetimeContext<'a> { | |||
| replace(&mut self.labels_in_fn, saved); | |||
| } | |||
|
|
|||
| fn visit_foreign_item(&mut self, item: &ast::ForeignItem) { | |||
| // Items save/restore the set of labels. This way innner items | |||
eefriedman
force-pushed
the
foreign-lifetime
branch
from
27296dc
to
ef23cbb
Compare
|
Amended to address review comments. |
|
Ping? |
|
Ping^2. |
|
r? @nrc |
| extern { | ||
| pub fn life<'a>(x:&'a i32); | ||
| pub fn life2<'b>(x:&'a i32, y:&'b i32); //~ ERROR use of undeclared lifetime name `'a` | ||
| pub fn life3<'a>(x:&'a i32, y:&i32) -> &'a i32; |
There was a problem hiding this comment.
Could you add lines to this test which test for bad lifetimes deeply nested in an argument type and in the return type please?
Also add a comment to the top of the test stating what is being tested.
|
Couple of minor things in the test, otherwise r=me |
Pretty straightforward; just need to make sure to explicitly handle the generic parameters of each ast::ForeignItemFn. Fixes rust-lang#26587.
eefriedman
force-pushed
the
foreign-lifetime
branch
from
ef23cbb
to
b221349
Compare
|
@nrc Updated test. |
|
@bors: r+ |
|
📌 Commit b221349 has been approved by |
bors
added a commit
that referenced
this pull request
Jul 23, 2015
Pretty straightforward; just need to make sure to explicitly handle the generic parameters of each ast::ForeignItemFn. Fixes #26587.
brson
added
the
relnotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty straightforward; just need to make sure to explicitly handle
the generic parameters of each ast::ForeignItemFn.
Fixes #26587.