Suggest using ref inline in an error

[ftxqxd]

The error now looks like this:

<anon>:4:9: 4:10 error: use of moved value: `x` [E0382]
<anon>:4     foo(x);
                 ^
<anon>:3:9: 3:10 note: `x` moved here because it has type `Box<i32>`, which is moved by default
<anon>:3     let y = x;
                 ^
<anon>:3:9: 3:10 help: use `ref` to take a reference instead:
<anon>:      let ref y = x;

[rust-highfive]

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

[sanxiyn]

Travis failure (license check) is real.

[ftxqxd]

Fixed.

[nikomatsakis]

Hmm. I'm not sure about this sort of help in general. I mean, taking a ref may be what they want, but it might not. Perhaps we can phrase this to make it clearer? Something like, "if you would like to borrow the value instead, you can use a ref binding, as shown".

[nikomatsakis]

Sorry, I know this is pre-existing :) I've just had this concern for a while...

[nikomatsakis]

Otherwise, looks really nice, and I'm happy to see span_suggestion getting more use.

[ftxqxd]

Good point—I’ve changed it to read if you would like to borrow the value instead, use arefbinding as shown: instead.

[nikomatsakis]

@bors r+ nice!

[bors]

📌 Commit 0bf9fbb has been approved by nikomatsakis