Fixed snippet to return the proper error. #27020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors: r+ rollup |
|
📌 Commit 2e1f75a has been approved by |
|
Thanks! :) |
bors
added a commit
that referenced
this pull request
Jul 14, 2015
…steveklabnik This PR fixes a snippet of code on the error handling chapter of "The Rust Programming Language". //cc @steveklabnik The docs state that trying to compile the snippet will yield the following error: ```bash anon>:13:5: 20:6 error: non-exhaustive patterns: `_` not covered [E0004] ``` But instead the error received is: ```bash <anon>:22:46: 22:56 error: unresolved name `NewRelease` <anon>:22 std::io::println(descriptive_probability(NewRelease)); ^~~~~~~~~~ <anon>:22:5: 22:21 error: unresolved name `std::io::println` <anon>:22 std::io::println(descriptive_probability(NewRelease)); ^~~~~~~~~~~~~~~~ error: aborting due to 2 previous errors playpen: application terminated with error code 101 ``` After applying this PR the expected error is returned: ```bash anon>:13:5: 20:6 error: non-exhaustive patterns: `_` not covered [E0004] <anon>:13 match probability(&event) { <anon>:14 1.00 => "certain", <anon>:15 0.00 => "impossible", <anon>:16 0.00 ... 0.25 => "very unlikely", <anon>:17 0.25 ... 0.50 => "unlikely", <anon>:18 0.50 ... 0.75 => "likely", ... <anon>:13:5: 20:6 help: see the detailed explanation for E0004 error: aborting due to previous error ```
|
💔 Test failed - auto-linux-32-opt |
|
@bors: retry On Tue, Jul 14, 2015 at 4:13 AM, bors notifications@github.com wrote:
|
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 16, 2015
…snippet, r=steveklabnik This PR fixes a snippet of code on the error handling chapter of \"The Rust Programming Language\". //cc @steveklabnik The docs state that trying to compile the snippet will yield the following error: ```bash anon>:13:5: 20:6 error: non-exhaustive patterns: `_` not covered [E0004] ``` But instead the error received is: ```bash <anon>:22:46: 22:56 error: unresolved name `NewRelease` <anon>:22 std::io::println(descriptive_probability(NewRelease)); ^~~~~~~~~~ <anon>:22:5: 22:21 error: unresolved name `std::io::println` <anon>:22 std::io::println(descriptive_probability(NewRelease)); ^~~~~~~~~~~~~~~~ error: aborting due to 2 previous errors playpen: application terminated with error code 101 ``` After applying this PR the expected error is returned: ```bash anon>:13:5: 20:6 error: non-exhaustive patterns: `_` not covered [E0004] <anon>:13 match probability(&event) { <anon>:14 1.00 => \"certain\", <anon>:15 0.00 => \"impossible\", <anon>:16 0.00 ... 0.25 => \"very unlikely\", <anon>:17 0.25 ... 0.50 => \"unlikely\", <anon>:18 0.50 ... 0.75 => \"likely\", ... <anon>:13:5: 20:6 help: see the detailed explanation for E0004 error: aborting due to previous error ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a snippet of code on the error handling chapter of "The Rust Programming Language".
//cc @steveklabnik
The docs state that trying to compile the snippet will yield the following error:
But instead the error received is:
After applying this PR the expected error is returned: