Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std: Add IntoRaw{Fd,Handle,Socket} traits #27064

Merged
merged 1 commit into from
Jul 20, 2015
Merged

std: Add IntoRaw{Fd,Handle,Socket} traits #27064

merged 1 commit into from
Jul 20, 2015

Conversation

alexcrichton
Copy link
Member

This commit is an implementation of RFC 1174 which adds three new traits
to the standard library:

  • IntoRawFd - implemented on Unix for all I/O types (files, sockets, etc)
  • IntoRawHandle - implemented on Windows for files, processes, etc
  • IntoRawSocket - implemented on Windows for networking types

Closes #27062

@alexcrichton
Copy link
Member Author

r? @aturon

@rust-highfive rust-highfive assigned aturon and brson and unassigned aturon Jul 16, 2015
@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@brson brson assigned aturon and unassigned brson Jul 16, 2015
@brson
Copy link
Contributor

brson commented Jul 16, 2015

@bors r+

@bors
Copy link
Contributor

bors commented Jul 16, 2015

📌 Commit dae6cda has been approved by brson

@Manishearth Manishearth mentioned this pull request Jul 17, 2015
Merged
@bors
Copy link
Contributor

bors commented Jul 17, 2015

☔ The latest upstream changes (presumably #27066) made this pull request unmergeable. Please resolve the merge conflicts.

bors added a commit that referenced this pull request Jul 17, 2015
@bors
Auto merge of #27082 - Manishearth:rollup, r=Manishearth
b5dad7d 
- Successful merges: #25993, #27038, #27069, #27070, #27080
- Failed merges: #27034, #27064
@bors
Copy link
Contributor

bors commented Jul 17, 2015

🔒 Merge conflict

@alexcrichton
Copy link
Member Author

@bors: r=brson 07bedf9

@bors
Copy link
Contributor

bors commented Jul 18, 2015

⌛ Testing commit 07bedf9 with merge fbf6ba7...

@bors
Copy link
Contributor

bors commented Jul 18, 2015

💔 Test failed - auto-win-gnu-32-nopt-t

@alexcrichton
Copy link
Member Author

@bors: r=brson

On Fri, Jul 17, 2015 at 6:10 PM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-win-gnu-32-nopt-t
http://buildbot.rust-lang.org/builders/auto-win-gnu-32-nopt-t/builds/708

—
Reply to this email directly or view it on GitHub
#27064 (comment).

@bors
Copy link
Contributor

bors commented Jul 18, 2015

📌 Commit 1de1d92 has been approved by brson

@bors
Copy link
Contributor

bors commented Jul 18, 2015

⌛ Testing commit 1de1d92 with merge 76b710c...

@bors
Copy link
Contributor

bors commented Jul 18, 2015

💔 Test failed - auto-win-gnu-32-opt

@alexcrichton
Copy link
Member Author

@bors: r=brson

On Sat, Jul 18, 2015 at 4:03 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-win-gnu-32-opt
http://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt/builds/716

—
Reply to this email directly or view it on GitHub
#27064 (comment).

@bors
Copy link
Contributor

bors commented Jul 20, 2015

📌 Commit 5a22a2e has been approved by brson

@bors
Copy link
Contributor

bors commented Jul 20, 2015

⌛ Testing commit 5a22a2e with merge 1116c90...

@bors
Copy link
Contributor

bors commented Jul 20, 2015

💔 Test failed - auto-win-gnu-32-opt

@alexcrichton
std: Add IntoRaw{Fd,Handle,Socket} traits
7e9e389 
This commit is an implementation of [RFC 1174][rfc] which adds three new traits
to the standard library:

* `IntoRawFd` - implemented on Unix for all I/O types (files, sockets, etc)
* `IntoRawHandle` - implemented on Windows for files, processes, etc
* `IntoRawSocket` - implemented on Windows for networking types

[rfc]: https://github.com/rust-lang/rfcs/blob/master/text/1174-into-raw-fd-socket-handle-traits.md

Closes rust-lang#27062
@alexcrichton
Copy link
Member Author

@bors: r=brson

On Mon, Jul 20, 2015 at 3:21 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-win-gnu-32-opt
http://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt/builds/737

—
Reply to this email directly or view it on GitHub
#27064 (comment).

@bors
Copy link
Contributor

bors commented Jul 20, 2015

📌 Commit 7e9e389 has been approved by brson

bors added a commit that referenced this pull request Jul 20, 2015
@bors
Auto merge of #27064 - alexcrichton:into-raw-os, r=brson
47265bb 
This commit is an implementation of [RFC 1174][rfc] which adds three new traits
to the standard library:

* `IntoRawFd` - implemented on Unix for all I/O types (files, sockets, etc)
* `IntoRawHandle` - implemented on Windows for files, processes, etc
* `IntoRawSocket` - implemented on Windows for networking types

[rfc]: https://github.com/rust-lang/rfcs/blob/master/text/1174-into-raw-fd-socket-handle-traits.md

Closes #27062
@bors
Copy link
Contributor

bors commented Jul 20, 2015

⌛ Testing commit 7e9e389 with merge 47265bb...

@bors
Copy link
Contributor

bors commented Jul 20, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt

@bors bors merged commit 7e9e389 into rust-lang:master Jul 20, 2015
@alexcrichton alexcrichton deleted the into-raw-os branch July 21, 2015 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexcrichton @rust-highfive @brson @bors @aturon