Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc: Add a --cap-lints flag to the compiler #27260

Merged
merged 1 commit into from
Jul 29, 2015

Conversation

alexcrichton
Copy link
Member

This commit is an implementation of RFC 1193 which adds the ability to
the compiler to cap the lint level for the entire compilation session. This flag
will ensure that no lints will go above this level, and Cargo will primarily use
this flag passing --cap-lints allow to all upstream dependencies.

Closes #27259

@alexcrichton
Copy link
Member Author

r? @nrc

@rust-highfive rust-highfive assigned nrc and unassigned nikomatsakis Jul 24, 2015
@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@@ -792,6 +794,8 @@ pub fn rustc_short_optgroups() -> Vec<RustcOptGroup> {
opt::multi("A", "allow", "Set lint allowed", "OPT"),
opt::multi("D", "deny", "Set lint denied", "OPT"),
opt::multi("F", "forbid", "Set lint forbidden", "OPT"),
opt::multi("", "cap-lints", "Prevent lint levels from being \
more restrictive", "LEVEL"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message is not very user-friendly, perhaps "Set the most restrictive lint level. More restrictive lints are capped at this level". Or something more concise.

@nrc
Copy link
Member

nrc commented Jul 28, 2015

r=me, with or without an improved message

This commit is an implementation of [RFC 1193][rfc] which adds the ability to
the compiler to cap the lint level for the entire compilation session. This flag
will ensure that no lints will go above this level, and Cargo will primarily use
this flag passing `--cap-lints allow` to all upstream dependencies.

[rfc]: rust-lang/rfcs#1193

Closes rust-lang#27259
@alexcrichton
Copy link
Member Author

@bors: r=nrc b345437

@bors
Copy link
Contributor

bors commented Jul 29, 2015

⌛ Testing commit b345437 with merge 68fc2d9...

bors added a commit that referenced this pull request Jul 29, 2015
This commit is an implementation of [RFC 1193][rfc] which adds the ability to
the compiler to cap the lint level for the entire compilation session. This flag
will ensure that no lints will go above this level, and Cargo will primarily use
this flag passing `--cap-lints allow` to all upstream dependencies.

[rfc]: rust-lang/rfcs#1193

Closes #27259
@bors bors merged commit b345437 into rust-lang:master Jul 29, 2015
@alexcrichton alexcrichton deleted the cap-lints branch August 17, 2015 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants