Makes formatting of struct keyword consistent #28182
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors: r+ rollup |
|
📌 Commit 28bf68f has been approved by |
|
Thanks! I was always unsure here, and just making them all this way is more consistent. Please just send individual PRs! They're easier to land. |
|
Cool! Sounds good. Thanks for your work on the book, it's been a great starting point! |
r? @steveklabnik ##### About the `struct` section specifically: I wasn't sure how you'd feel about the first instance since it was originally capitalized, happy to change it back if you think that's better. Also, I left 'tuple struct' as is since together it isn't a keyword. The first instance currently has single quotes but the others have nothing. I think that feels right. ##### Generally: I'm working through the book now and I'm happy to keep updating this branch with any formatting tweaks or updates I find if that's easier for you guys, otherwise I'll just create smaller PRs as I go. Just let me know.
r? @steveklabnik
About the
structsection specifically:I wasn't sure how you'd feel about the first instance since it was originally capitalized, happy to change it back if you think that's better.
Also, I left 'tuple struct' as is since together it isn't a keyword. The first instance currently has single quotes but the others have nothing. I think that feels right.
Generally:
I'm working through the book now and I'm happy to keep updating this branch with any formatting tweaks or updates I find if that's easier for you guys, otherwise I'll just create smaller PRs as I go. Just let me know.