std: Stabilize/deprecate features for 1.4 #28339

alexcrichton · 2015-09-10T20:54:44Z

The FCP is coming to a close and 1.4 is coming out soon, so this brings in the
libs team decision for all library features this cycle.

Stabilized APIs:

<Box<str>>::into_string
Arc::downgrade
Arc::get_mut
Arc::make_mut
Arc::try_unwrap
Box::from_raw
Box::into_raw
CStr::to_str
CStr::to_string_lossy
CString::from_raw
CString::into_raw
IntoRawFd::into_raw_fd
IntoRawFd
IntoRawHandle::into_raw_handle
IntoRawHandle
IntoRawSocket::into_raw_socket
IntoRawSocket
Rc::downgrade
Rc::get_mut
Rc::make_mut
Rc::try_unwrap
Result::expect
String::into_boxed_slice
TcpSocket::read_timeout
TcpSocket::set_read_timeout
TcpSocket::set_write_timeout
TcpSocket::write_timeout
UdpSocket::read_timeout
UdpSocket::set_read_timeout
UdpSocket::set_write_timeout
UdpSocket::write_timeout
Vec::append
Vec::split_off
VecDeque::append
VecDeque::retain
VecDeque::split_off
rc::Weak::upgrade
rc::Weak
slice::Iter::as_slice
slice::IterMut::into_slice
str::CharIndices::as_str
str::Chars::as_str
str::split_at_mut
str::split_at
sync::Weak::upgrade
sync::Weak
thread::park_timeout
thread::sleep

Deprecated APIs

BTreeMap::with_b
BTreeSet::with_b
Option::as_mut_slice
Option::as_slice
Result::as_mut_slice
Result::as_slice
f32::from_str_radix
f64::from_str_radix

Closes #27277
Closes #27718
Closes #27736
Closes #27764
Closes #27765
Closes #27766
Closes #27767
Closes #27768
Closes #27769
Closes #27771
Closes #27773
Closes #27775
Closes #27776
Closes #27785
Closes #27792
Closes #27795
Closes #27797

rust-highfive · 2015-09-10T20:54:49Z

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

alexcrichton · 2015-09-10T20:55:06Z

cc @rust-lang/libs

r? @aturon

eefriedman · 2015-09-10T21:53:42Z

src/liballoc/rc.rs

@@ -263,7 +261,8 @@ impl<T> Rc<T> {
    }

    /// Checks if `Rc::try_unwrap` would return `Ok`.
-    #[unstable(feature = "rc_would_unwrap", reason = "just added for niche usecase",
+    #[unstable(feature = "rc_would_unwrap",
+               reason = "just added for niche usecase",
               issue = "27718")]


This needs a new issue number: this PR closes 27718.

Gankra · 2015-09-10T21:59:17Z

I thought people didn't like append as a name?

eefriedman · 2015-09-10T22:12:40Z

src/libstd/net/tcp.rs

+    /// Platforms may return a different error code whenever a read times out as
+    /// a result of setting this option. For example Unix typically returns an
+    /// error of the kind `WouldBlock`, but Windows may return `TimedOut`.
+    #[stable(feature = "socket_timeout", since = "1.4.0")]


Are we really sure this is ready to be stabilized? I'm not sure the questions brought up in #27773 have been sufficiently addressed.

If you're sure this is ready to be stabilized, for the comment, I would suggest something more like "The exact meaning of the timeout is platform-specific; reads may block for longer than the given duration. There is no portable way to detect if a read has timed out due to this timeout; the connection should be closed if a read fails with WouldBlock or TimedOut."

Yes, the purpose of this function is to bind the SO_RCVTIMEO option, and it's what it's doing on all platforms. Whether or not this is exactly what you want for your application will depend on use cases, but this provides the appropriate Rust interface to getting/setting these options.

To elaborate on this a bit: we discussed #27773 extensively in the libs team meeting, and I've written up the results of that discussion in a new comment there.

alexcrichton · 2015-09-11T16:44:25Z

@gankro

I thought people didn't like append as a name?

We discussed this in the libs team meaning, but the ship has long sailed on this. These functions have gone through RFCs multiple times almost, and the functionality is already stable on LinkedList.

The FCP is coming to a close and 1.4 is coming out soon, so this brings in the libs team decision for all library features this cycle. Stabilized APIs: * `<Box<str>>::into_string` * `Arc::downgrade` * `Arc::get_mut` * `Arc::make_mut` * `Arc::try_unwrap` * `Box::from_raw` * `Box::into_raw` * `CStr::to_str` * `CStr::to_string_lossy` * `CString::from_raw` * `CString::into_raw` * `IntoRawFd::into_raw_fd` * `IntoRawFd` * `IntoRawHandle::into_raw_handle` * `IntoRawHandle` * `IntoRawSocket::into_raw_socket` * `IntoRawSocket` * `Rc::downgrade` * `Rc::get_mut` * `Rc::make_mut` * `Rc::try_unwrap` * `Result::expect` * `String::into_boxed_slice` * `TcpSocket::read_timeout` * `TcpSocket::set_read_timeout` * `TcpSocket::set_write_timeout` * `TcpSocket::write_timeout` * `UdpSocket::read_timeout` * `UdpSocket::set_read_timeout` * `UdpSocket::set_write_timeout` * `UdpSocket::write_timeout` * `Vec::append` * `Vec::split_off` * `VecDeque::append` * `VecDeque::retain` * `VecDeque::split_off` * `rc::Weak::upgrade` * `rc::Weak` * `slice::Iter::as_slice` * `slice::IterMut::into_slice` * `str::CharIndices::as_str` * `str::Chars::as_str` * `str::split_at_mut` * `str::split_at` * `sync::Weak::upgrade` * `sync::Weak` * `thread::park_timeout` * `thread::sleep` Deprecated APIs * `BTreeMap::with_b` * `BTreeSet::with_b` * `Option::as_mut_slice` * `Option::as_slice` * `Result::as_mut_slice` * `Result::as_slice` * `f32::from_str_radix` * `f64::from_str_radix` Closes rust-lang#27277 Closes rust-lang#27718 Closes rust-lang#27736 Closes rust-lang#27764 Closes rust-lang#27765 Closes rust-lang#27766 Closes rust-lang#27767 Closes rust-lang#27768 Closes rust-lang#27769 Closes rust-lang#27771 Closes rust-lang#27773 Closes rust-lang#27775 Closes rust-lang#27776 Closes rust-lang#27785 Closes rust-lang#27792 Closes rust-lang#27795 Closes rust-lang#27797

aturon · 2015-09-11T17:18:22Z

@gankro

I thought people didn't like append as a name?

We discussed this in the libs team meaning, but the ship has long sailed on this. These functions have gone through RFCs multiple times almost, and the functionality is already stable on LinkedList.

In particular, if we want to rename, we have to deal with the existing stable functionality. In general, we signed off on completing the collection reform RFC implementation by stabilizing consistent APIs across the collections where they're appropriate.

aturon · 2015-09-11T17:32:40Z

OK, I've checked this over, and r=me -- but I want to give others a bit more time to comment before we send to bors.

Gankra · 2015-09-11T18:08:15Z

shrug works for me

Gankra · 2015-09-11T18:08:34Z

Wait

Or we could deprecate LinkedList

HMMM???

alexcrichton · 2015-09-13T17:09:54Z

@bors: r=aturon

bors · 2015-09-13T17:09:55Z

📌 Commit f0b1326 has been approved by aturon

bors · 2015-09-13T19:45:17Z

⌛ Testing commit f0b1326 with merge cedbd99...

The FCP is coming to a close and 1.4 is coming out soon, so this brings in the libs team decision for all library features this cycle. Stabilized APIs: * `<Box<str>>::into_string` * `Arc::downgrade` * `Arc::get_mut` * `Arc::make_mut` * `Arc::try_unwrap` * `Box::from_raw` * `Box::into_raw` * `CStr::to_str` * `CStr::to_string_lossy` * `CString::from_raw` * `CString::into_raw` * `IntoRawFd::into_raw_fd` * `IntoRawFd` * `IntoRawHandle::into_raw_handle` * `IntoRawHandle` * `IntoRawSocket::into_raw_socket` * `IntoRawSocket` * `Rc::downgrade` * `Rc::get_mut` * `Rc::make_mut` * `Rc::try_unwrap` * `Result::expect` * `String::into_boxed_slice` * `TcpSocket::read_timeout` * `TcpSocket::set_read_timeout` * `TcpSocket::set_write_timeout` * `TcpSocket::write_timeout` * `UdpSocket::read_timeout` * `UdpSocket::set_read_timeout` * `UdpSocket::set_write_timeout` * `UdpSocket::write_timeout` * `Vec::append` * `Vec::split_off` * `VecDeque::append` * `VecDeque::retain` * `VecDeque::split_off` * `rc::Weak::upgrade` * `rc::Weak` * `slice::Iter::as_slice` * `slice::IterMut::into_slice` * `str::CharIndices::as_str` * `str::Chars::as_str` * `str::split_at_mut` * `str::split_at` * `sync::Weak::upgrade` * `sync::Weak` * `thread::park_timeout` * `thread::sleep` Deprecated APIs * `BTreeMap::with_b` * `BTreeSet::with_b` * `Option::as_mut_slice` * `Option::as_slice` * `Result::as_mut_slice` * `Result::as_slice` * `f32::from_str_radix` * `f64::from_str_radix` Closes #27277 Closes #27718 Closes #27736 Closes #27764 Closes #27765 Closes #27766 Closes #27767 Closes #27768 Closes #27769 Closes #27771 Closes #27773 Closes #27775 Closes #27776 Closes #27785 Closes #27792 Closes #27795 Closes #27797

bors · 2015-09-13T21:27:05Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

rust-highfive assigned pcwalton Sep 10, 2015

alexcrichton force-pushed the stabilize-1.4 branch from b384ce1 to b7a319d Compare September 10, 2015 20:55

rust-highfive assigned aturon and unassigned pcwalton Sep 10, 2015

alexcrichton force-pushed the stabilize-1.4 branch 3 times, most recently from 1db2831 to 68e1b65 Compare September 10, 2015 21:04

eefriedman reviewed Sep 10, 2015
View reviewed changes

alexcrichton force-pushed the stabilize-1.4 branch from 68e1b65 to b20b26f Compare September 11, 2015 16:46

alexcrichton force-pushed the stabilize-1.4 branch from b20b26f to f0b1326 Compare September 13, 2015 17:09

bors merged commit f0b1326 into rust-lang:master Sep 13, 2015

bors mentioned this pull request Sep 13, 2015

Correctly walk import lists in AST visitors #28364

Merged

nasa42 mentioned this pull request Sep 14, 2015

TWiR Release 96 (14 September 2015). rust-lang/this-week-in-rust#119

Merged

bluss added the relnotes Marks issues that should be documented in the release notes of the next release. label Sep 15, 2015

alexcrichton deleted the stabilize-1.4 branch September 17, 2015 18:05

yoshuawuyts mentioned this pull request Mar 6, 2020

[libs] Add TcpStream::keepalive and TcpStream::set_keepalive #69774

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

std: Stabilize/deprecate features for 1.4 #28339

std: Stabilize/deprecate features for 1.4 #28339

alexcrichton commented Sep 10, 2015

rust-highfive commented Sep 10, 2015

alexcrichton commented Sep 10, 2015

eefriedman Sep 10, 2015

Gankra commented Sep 10, 2015

eefriedman Sep 10, 2015

alexcrichton Sep 11, 2015

aturon Sep 11, 2015

alexcrichton commented Sep 11, 2015

aturon commented Sep 11, 2015

aturon commented Sep 11, 2015

Gankra commented Sep 11, 2015

Gankra commented Sep 11, 2015

alexcrichton commented Sep 13, 2015

bors commented Sep 13, 2015

bors commented Sep 13, 2015

bors commented Sep 13, 2015

std: Stabilize/deprecate features for 1.4 #28339

std: Stabilize/deprecate features for 1.4 #28339

Conversation

alexcrichton commented Sep 10, 2015

rust-highfive commented Sep 10, 2015

alexcrichton commented Sep 10, 2015

eefriedman Sep 10, 2015

Choose a reason for hiding this comment

Gankra commented Sep 10, 2015

eefriedman Sep 10, 2015

Choose a reason for hiding this comment

alexcrichton Sep 11, 2015

Choose a reason for hiding this comment

aturon Sep 11, 2015

Choose a reason for hiding this comment

alexcrichton commented Sep 11, 2015

aturon commented Sep 11, 2015

aturon commented Sep 11, 2015

Gankra commented Sep 11, 2015

Gankra commented Sep 11, 2015

alexcrichton commented Sep 13, 2015

bors commented Sep 13, 2015

bors commented Sep 13, 2015

bors commented Sep 13, 2015