Add map::clear #2846
Merged
Add map::clear #2846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add clear to the map interface, and implement it in hashmap and smallintmap.
|
The answer to my question appears to be no: if you tie a pull request to a commit, you can't change it later. This is too bad. (I didn't like the other workflow, because if I rewrite history to squash the new commit onto the old one to keep it clean, the pull request forgets the old one ever existed. I thought maybe this would not do that. I guess to keep history in a pull request you have to keep the history of the commits and not squash them once it's filed.) |
|
Thanks! |
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Apr 28, 2023
Remove a test that wasn't carrying its weight See rust-lang#110107 (comment) for discussion. TLDR: it keeps breaking out of unrelated reasons and the real thing to check (early alloc ids can be tracked without ICEing miri) is hard to check otherwise.
celinval
pushed a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
Update Rust toolchain to `nightly-2023-10-31`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add clear to the map interface, and implement it in hashmap and smallintmap. This fixes #2775.
I didn't add anything to treemap, which notably doesn't implement map.
I tied my pull request to a specific commit this time instead of a branch; I'm not sure whether that's better, or whether I'll be able to change what commit, if I need to revise it. We'll see!