Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize the types of foreign functions #29001

Merged
merged 1 commit into from
Oct 14, 2015

Conversation

arielb1
Copy link
Contributor

@arielb1 arielb1 commented Oct 12, 2015

This is needed as item types are allowed to be unnormalized.

Fixes an ICE that occurs when foreign function signatures contained
an associated type.

Fixes #28983

This is needed as item types are allowed to be unnormalized.

Fixes an ICE that occurs when foreign function signatures contained
an associated type.

Fixes rust-lang#28983
@arielb1
Copy link
Contributor Author

arielb1 commented Oct 12, 2015

r? @eddyb

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive assigned eddyb and unassigned nikomatsakis Oct 12, 2015
@eddyb
Copy link
Member

eddyb commented Oct 12, 2015

@bors r+

@bors
Copy link
Contributor

bors commented Oct 12, 2015

📌 Commit bee664f has been approved by eddyb

@bors
Copy link
Contributor

bors commented Oct 12, 2015

⌛ Testing commit bee664f with merge e5e6bc1...

@bors
Copy link
Contributor

bors commented Oct 12, 2015

💔 Test failed - auto-linux-64-x-android-t

@alexcrichton
Copy link
Member

@bors: retry

On Mon, Oct 12, 2015 at 4:23 PM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-linux-64-x-android-t
http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/6684


Reply to this email directly or view it on GitHub
#29001 (comment).

@bors
Copy link
Contributor

bors commented Oct 12, 2015

⌛ Testing commit bee664f with merge d0cc657...

@alexcrichton
Copy link
Member

@bors: retry force

@bors
Copy link
Contributor

bors commented Oct 14, 2015

⌛ Testing commit bee664f with merge 18268bf...

bors added a commit that referenced this pull request Oct 14, 2015
This is needed as item types are allowed to be unnormalized.

Fixes an ICE that occurs when foreign function signatures contained
an associated type.

Fixes #28983
@bors bors merged commit bee664f into rust-lang:master Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants