Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require a method callee's type to outlive the call #29006

Merged
merged 1 commit into from
Oct 14, 2015

Commits on Oct 12, 2015

  1. require a method callee's type to outlive the call

    This rather crucial requirement was not checked. In most cases, that
    didn't cause any trouble because the argument types are required to
    outlive the call and are subtypes of a subformula of the callee type.
    
    However, binary ops are taken by ref only indirectly, without it being
    marked in the argument types, which led to the argument types not being
    constrained anywhere causing spurious errors (as these are basically
    unconstrainable, I don't think this change can break code). Of course,
    the old way was also incorrent with contravariance, but that is still
    unsound for other reasons.
    
    This also improves rustc::front to get RUST_LOG to *somewhat* work.
    
    Fixes rust-lang#28999
    arielb1 committed Oct 12, 2015
    Configuration menu
    Copy the full SHA
    ed2a11d View commit details
    Browse the repository at this point in the history