std: Implement FromStr for SocketAddrV{4,6} #29190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was already implemented for SocketAddr, so the other types are lacking it is just an oversight! Closes rust-lang#29183
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ |
|
📌 Commit 8aa6a11 has been approved by |
brson
added
the
relnotes
|
⌛ Testing commit 8aa6a11 with merge ff5cc89... |
bors
added a commit
that referenced
this pull request
Oct 21, 2015
This was already implemented for SocketAddr, so the other types are lacking it is just an oversight! Closes #29183
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was already implemented for SocketAddr, so the other types are lacking it
is just an oversight!
Closes #29183