Rustfmt #29282
Closed
Rustfmt #29282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
October 24, 2015 20:09
I'm not sure about this one. Imo it makes it less readable.
- remove extra spaces, or add some when necessary - split single lines into multiple lines - fix indentation - add missing commas
Not sure if this is very readable?
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
r? @nrc |
|
Geez I missed that someone else already started to work on the same thing at #28907 :( I'll look for another one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to run rusmft on libterm. It is work in progress, but since it's pretty big and it's my first ever rust contribution, I'd appreciate some feedback I tried to split that in small commits. The commit messages that contain [UNSURE] are those for which I'm not sure if rustfmt is right.
Thanks @nrc for giving newbies a chance to contribute to actual code :) I found a few issues in rustfmt doing this, I'll open issues soon.