Make RFC 1214 warnings into errors #30389
Conversation
|
LGTM, seems to me like a nice clean up pass. |
|
At last! @bors r+ |
|
@bors r=arielb1 |
|
📌 Commit b5d024d has been approved by |
|
☔ The latest upstream changes (presumably #30410) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@Manishearth to be clear, this did NOT land as part of some rollup, right? |
|
Yeah, this didn't get rolled up. I tried to, but there were merge conflicts (which is why it got mentioned by the rollups) (Probably should have prioritized this one and fixed the smaller merge conflicts instead of breaking this PR, but I didn't notice that this PR touched so much. Sorry.) |
nikomatsakis
force-pushed
the
rfc1214-error
branch
from
b5d024d to
cd8e914
Compare
|
@bors r=arielb1 p=1 |
|
📌 Commit cd8e914 has been approved by |
|
Giving p=1 because this is conflict prone and better to land sooner rather than later so people have more time to adapt. |
associated machinery. Future such attempts should go through lints anyhow. There is a fair amount of fallout in the compile-fail tests, as WF checking now occurs earlier in the process.
nikomatsakis
force-pushed
the
rfc1214-error
branch
from
cd8e914 to
dbf994b
Compare
|
@bors r=arielb1 p=1 |
|
📌 Commit dbf994b has been approved by |
Make RFC 1214 warnings into errors, and rip out the "warn or err" associated machinery. Future such attempts should go through lints anyhow. There is a fair amount of fallout in the compile-fail tests, as WF checking now occurs earlier in the process. r? @arielb1
bluss
added
the
relnotes
Make RFC 1214 warnings into errors, and rip out the "warn or err"
associated machinery. Future such attempts should go through lints
anyhow.
There is a fair amount of fallout in the compile-fail tests, as WF
checking now occurs earlier in the process.
r? @arielb1