run rustfmt on syntax::parse::lexer #30684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| style: if code_to_the_left { Trailing } else { Isolated }, | ||
| lines: vec!(rdr.read_one_line_comment()), | ||
| pos: p | ||
| style: if code_to_the_left { |
There was a problem hiding this comment.
Bad formatting. (Comment copied from the previous PR.)
There was a problem hiding this comment.
I prefer these in separate lines... I prefer what rustfmt did.
|
r? @nrc |
|
There's a comment missing around line -1279/+1466 |
|
r+ with the missing comment addressed. |
|
r? @nrc |
|
That comment makes me a little confused... why is the shebang considered a comment? |
|
You can start a Rust program with a shebang, and it is ignored by Rust, i.e., treated as a comment. Only shells and so forth would process it. |
|
@bors: r+ |
|
📌 Commit aa3b4c6 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.