[MIR] Factor mir::[Mut]Visitor implementations into a common macro. #30757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelwoerister
added
the
A-MIR
|
r? @jroesch (rust_highfive has picked a reviewer for you, use r? to override) |
|
Looks good to me, I really wish we had a way to abstract over mutability. |
|
@bors r+ |
|
📌 Commit 8f51188 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 7, 2016
After a call to `visit_def_id()` missing in `mir::visit::Visitor` but not `mir::visit::MutVisitor` has caused me a couple hours of error hunting, I decided I'd take the time to get rid of the code duplication between the two implementations. cc @rust-lang/compiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a call to
visit_def_id()missing inmir::visit::Visitorbut notmir::visit::MutVisitorhas caused me a couple hours of error hunting, I decided I'd take the time to get rid of the code duplication between the two implementations.cc @rust-lang/compiler