Fix memory leak in resolve #30863
Merged
Fix memory leak in resolve #30863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le`s to fix memory leaks from Rc cycles
|
r? @eddyb |
|
Nice catch! I thought we were using |
| @@ -1170,7 +1167,7 @@ pub struct Resolver<'a, 'tcx: 'a> { | |||
|
|
|||
| ast_map: &'a hir_map::Map<'tcx>, | |||
There was a problem hiding this comment.
This seems to infect everything with 'tcx but it's improper, it should be 'hir instead ('tcx is for the type context, which we do not have here).
Not really blocking this PR, just that it's the first time I notice it.
|
@bors r+ |
|
📌 Commit a8514d3 has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jan 14, 2016
Use arena allocation instead of reference counting for `Module`s to fix memory leaks from `Rc` cycles.
A module references its module children and its import resolutions, and an import resolution references the module defining the imported name, so there is a cycle whenever a module imports something from an ancestor module.
For example,
```rust
mod foo { // `foo` references `bar`.
fn baz() {}
mod bar { // `bar` references the import.
use foo::baz; // The import references `foo`.
}
}
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use arena allocation instead of reference counting for
Modules to fix memory leaks fromRccycles.A module references its module children and its import resolutions, and an import resolution references the module defining the imported name, so there is a cycle whenever a module imports something from an ancestor module.
For example,