-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for mips(el)-unknown-linux-musl #31298
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
# mips-unknown-linux-musl configuration | ||
CC_mips-unknown-linux-musl=mips-linux-musl-gcc | ||
CXX_mips-unknown-linux-musl=mips-linux-musl-g++ | ||
CPP_mips-unknown-linux-musl=mips-linux-musl-gcc -E | ||
AR_mips-unknown-linux-musl=mips-linux-musl-ar | ||
CFG_LIB_NAME_mips-unknown-linux-musl=lib$(1).so | ||
CFG_STATIC_LIB_NAME_mips-unknown-linux-musl=lib$(1).a | ||
CFG_LIB_GLOB_mips-unknown-linux-musl=lib$(1)-*.so | ||
CFG_LIB_DSYM_GLOB_mips-unknown-linux-musl=lib$(1)-*.dylib.dSYM | ||
CFG_JEMALLOC_CFLAGS_mips-unknown-linux-musl := -mips32r2 -msoft-float -mabi=32 $(CFLAGS) | ||
CFG_GCCISH_CFLAGS_mips-unknown-linux-musl := -Wall -g -fPIC -mips32r2 -msoft-float -mabi=32 $(CFLAGS) | ||
CFG_GCCISH_CXXFLAGS_mips-unknown-linux-musl := -fno-rtti $(CXXFLAGS) | ||
CFG_GCCISH_LINK_FLAGS_mips-unknown-linux-musl := -shared -fPIC -g -mips32r2 -msoft-float -mabi=32 | ||
CFG_GCCISH_DEF_FLAG_mips-unknown-linux-musl := -Wl,--export-dynamic,--dynamic-list= | ||
CFG_LLC_FLAGS_mips-unknown-linux-musl := | ||
CFG_INSTALL_NAME_mips-unknown-linux-musl = | ||
CFG_EXE_SUFFIX_mips-unknown-linux-musl = | ||
CFG_WINDOWSY_mips-unknown-linux-musl := | ||
CFG_UNIXY_mips-unknown-linux-musl := 1 | ||
CFG_LDPATH_mips-unknown-linux-musl := | ||
CFG_RUN_mips-unknown-linux-musl= | ||
CFG_RUN_TARG_mips-unknown-linux-musl= | ||
RUSTC_FLAGS_mips-unknown-linux-musl := | ||
CFG_GNU_TRIPLE_mips-unknown-linux-musl := mips-unknown-linux-musl |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
# mipsel-unknown-linux-musl configuration | ||
CC_mipsel-unknown-linux-musl=mipsel-linux-musl-gcc | ||
CXX_mipsel-unknown-linux-musl=mipsel-linux-musl-g++ | ||
CPP_mipsel-unknown-linux-musl=mipsel-linux-musl-gcc | ||
AR_mipsel-unknown-linux-musl=mipsel-linux-musl-ar | ||
CFG_LIB_NAME_mipsel-unknown-linux-musl=lib$(1).so | ||
CFG_STATIC_LIB_NAME_mipsel-unknown-linux-musl=lib$(1).a | ||
CFG_LIB_GLOB_mipsel-unknown-linux-musl=lib$(1)-*.so | ||
CFG_LIB_DSYM_GLOB_mipsel-unknown-linux-musl=lib$(1)-*.dylib.dSYM | ||
CFG_JEMALLOC_CFLAGS_mipsel-unknown-linux-musl := -mips32 -mabi=32 $(CFLAGS) | ||
CFG_GCCISH_CFLAGS_mipsel-unknown-linux-musl := -Wall -g -fPIC -mips32 -mabi=32 $(CFLAGS) | ||
CFG_GCCISH_CXXFLAGS_mipsel-unknown-linux-musl := -fno-rtti $(CXXFLAGS) | ||
CFG_GCCISH_LINK_FLAGS_mipsel-unknown-linux-musl := -shared -fPIC -g -mips32 | ||
CFG_GCCISH_DEF_FLAG_mipsel-unknown-linux-musl := -Wl,--export-dynamic,--dynamic-list= | ||
CFG_LLC_FLAGS_mipsel-unknown-linux-musl := | ||
CFG_INSTALL_NAME_mipsel-unknown-linux-musl = | ||
CFG_EXE_SUFFIX_mipsel-unknown-linux-musl := | ||
CFG_WINDOWSY_mipsel-unknown-linux-musl := | ||
CFG_UNIXY_mipsel-unknown-linux-musl := 1 | ||
CFG_LDPATH_mipsel-unknown-linux-musl := | ||
CFG_RUN_mipsel-unknown-linux-musl= | ||
CFG_RUN_TARG_mipsel-unknown-linux-musl= | ||
RUSTC_FLAGS_mipsel-unknown-linux-musl := | ||
CFG_GNU_TRIPLE_mipsel-unknown-linux-musl := mipsel-unknown-linux-musl |
Submodule liblibc
updated
from 91ff43 to 30f70b
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
use target::{Target, TargetOptions}; | ||
|
||
pub fn target() -> Target { | ||
Target { | ||
llvm_target: "mips-unknown-linux-musl".to_string(), | ||
target_endian: "big".to_string(), | ||
target_pointer_width: "32".to_string(), | ||
arch: "mips".to_string(), | ||
target_os: "linux".to_string(), | ||
target_env: "musl".to_string(), | ||
target_vendor: "unknown".to_string(), | ||
options: TargetOptions { | ||
cpu: "mips32r2".to_string(), | ||
features: "+mips32r2,+soft-float".to_string(), | ||
..super::linux_base::opts() | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
use target::{Target, TargetOptions}; | ||
|
||
pub fn target() -> Target { | ||
Target { | ||
llvm_target: "mipsel-unknown-linux-musl".to_string(), | ||
target_endian: "little".to_string(), | ||
target_pointer_width: "32".to_string(), | ||
arch: "mips".to_string(), | ||
target_os: "linux".to_string(), | ||
target_env: "musl".to_string(), | ||
target_vendor: "unknown".to_string(), | ||
options: TargetOptions { | ||
cpu: "mips32".to_string(), | ||
features: "+mips32".to_string(), | ||
..super::linux_base::opts() | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -93,11 +93,20 @@ mod arch { | |
use os::raw::{c_long, c_ulong}; | ||
use os::unix::raw::{gid_t, uid_t}; | ||
|
||
#[cfg(target_env = "musl")] | ||
#[stable(feature = "raw_ext", since = "1.1.0")] pub type blkcnt_t = i64; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure what stability level this should have. AFAIK, these types are going to be deprecated in the future. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah yeah these are fine to stay as-is |
||
#[cfg(not(target_env = "musl"))] | ||
#[stable(feature = "raw_ext", since = "1.1.0")] pub type blkcnt_t = i32; | ||
#[stable(feature = "raw_ext", since = "1.1.0")] pub type blksize_t = i32; | ||
#[cfg(target_env = "musl")] | ||
#[stable(feature = "raw_ext", since = "1.1.0")] pub type ino_t = u64; | ||
#[cfg(not(target_env = "musl"))] | ||
#[stable(feature = "raw_ext", since = "1.1.0")] pub type ino_t = u32; | ||
#[stable(feature = "raw_ext", since = "1.1.0")] pub type nlink_t = u32; | ||
#[cfg(target_env = "musl")] | ||
#[stable(feature = "raw_ext", since = "1.1.0")] pub type off_t = i32; | ||
#[cfg(not(target_env = "musl"))] | ||
#[stable(feature = "raw_ext", since = "1.1.0")] pub type off_t = i64; | ||
#[stable(feature = "raw_ext", since = "1.1.0")] pub type time_t = i32; | ||
|
||
#[repr(C)] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be mipsel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure! The existing
mipsel-unknown-linux-gnu
target is also usingmips
as the arch.AIUI, this arch field is used for
#[cfg(target_arch = ...)]
and not for codegen (that's what llvm-target is used for). If we want to change both targets (mipsel-gnu and mipsel-musl) to use arch = mipsel, then we'll have to update the cfgs in crates like libc from#[cfg(target_arch = "mips")]
to#[cfg(any(target_arch = "mips", any(target_arch = "mipsel"))]
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh interesting! That may be a bug in the target triple, however, depending on how you look at it. Either that or we may just want to make sure that we're consistent. Some data points:
powerpc64le-unknown-linux-gnu
triple haspowerpc64le
as thetarget_arch
.cfg(target_arch = "mipsel")
directives in the standard library, which apparently are doing nothing.target_arch
, for examplearmv7
recently added has thetarget_arch
ofarm
.I think that I'd prefer to lean towards leaving this as
mips
and tweaking thepowerpc64le
triple to havepowerpc64
as thetarget_arch
. That seems the most consistent to me and also the most ergonomic. The two triples can still be differentiated by looking attarget_endian
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 from me