Optimize some functions in std::process #31618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
force-pushed
the
no-thread-spawns
branch
2 times, most recently
from
db8d041 to
63ca1d9
Compare
|
☔ The latest upstream changes (presumably #31825) made this pull request unmergeable. Please resolve the merge conflicts. |
alexcrichton
force-pushed
the
no-thread-spawns
branch
from
63ca1d9 to
2e9dbf1
Compare
|
☔ The latest upstream changes (presumably #31858) made this pull request unmergeable. Please resolve the merge conflicts. |
alexcrichton
force-pushed
the
no-thread-spawns
branch
from
2e9dbf1 to
956de96
Compare
|
@bors r+ Glad to see that thread go. |
|
📌 Commit 956de96 has been approved by |
|
⌛ Testing commit 956de96 with merge 3365f3b... |
|
💔 Test failed - auto-win-msvc-64-opt |
alexcrichton
force-pushed
the
no-thread-spawns
branch
from
956de96 to
b49d4b1
Compare
|
@bors: r=brson b49d4b1 |
|
⌛ Testing commit b49d4b1 with merge c2e412c... |
|
💔 Test failed - auto-win-msvc-64-opt |
alexcrichton
force-pushed
the
no-thread-spawns
branch
from
b49d4b1 to
58e96a8
Compare
|
@bors: r=brson 58e96a8 |
|
⌛ Testing commit 58e96a8 with merge 4274c2a... |
|
@bors: retry force |
|
⌛ Testing commit 58e96a8 with merge 1b87ace... |
|
💔 Test failed - auto-linux-64-x-android-t |
alexcrichton
force-pushed
the
no-thread-spawns
branch
from
58e96a8 to
3ff611f
Compare
|
@bors: r=brson 3ff611f |
|
⌛ Testing commit 3ff611f with merge 3e4519e... |
|
@bors: retry force |
|
⌛ Testing commit 7c3038f with merge 9fbff29... |
|
💔 Test failed - auto-mac-64-opt |
|
@bors: retry |
bors
added a commit
that referenced
this pull request
Mar 10, 2016
Optimize some functions in std::process * Be sure that `read_to_end` gets directed towards `read_to_end_uninitialized` for all handles * When spawning a child that guaranteed doesn't need a stdin, don't actually create a stdin pipe for that process, instead just redirect it to /dev/null * When calling `wait_with_output`, don't spawn threads to read out the pipes of the child. Instead drain all pipes on the calling thread and *then* wait on the process. Functionally, it is intended that nothing changes as part of this PR --- Note that this was the same as #31613, and even after that it turned out that fixing Windows was easier than I thought! To copy a comment from over there: > As some rationale for this as well, it's always bothered me that we've spawned threads in the standard library for this (seems a bit overkill), and I've also been curious lately as to our why our build times for Windows are so much higher than Unix (on the buildbots we have). I have done basically 0 investigation into why, but I figured it can't help to try to optimize Command::output which I believe is called quite a few times during the test suite.
|
😲 |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 15, 2016
This regression was accidentally introduced in rust-lang#31618, and it's just flipping a boolean! Closes rust-lang#32254
This was referenced Mar 15, 2016
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 26, 2016
…uron std: Fix inheriting stdin on status() This regression was accidentally introduced in rust-lang#31618, and it's just flipping a boolean! Closes rust-lang#32254
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 26, 2016
…uron std: Fix inheriting stdin on status() This regression was accidentally introduced in rust-lang#31618, and it's just flipping a boolean! Closes rust-lang#32254
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 4, 2017
This commit fixes a mistake introduced in rust-lang#31618 where overlapped handles were leaked to child processes on Windows. On Windows once a handle is in overlapped mode it should always have I/O executed with an instance of `OVERLAPPED`. Most child processes, however, are not prepared to have their stdio handles in overlapped mode as they don't use `OVERLAPPED` on reads/writes to the handle. Now we haven't had any odd behavior in Rust up to this point, and the original bug was introduced almost a year ago. I believe this is because it turns out that if you *don't* pass an `OVERLAPPED` then the system will [supply one for you][link]. In this case everything will go awry if you concurrently operate on the handle. In Rust, however, the stdio handles are always locked, and there's no way to not use them unlocked in libstd. Due to that change we've always had synchronized access to these handles, which means that Rust programs typically "just work". Conversely, though, this commit fixes the test case included, which exhibits behavior that other programs Rust spawns may attempt to execute. Namely, the stdio handles may be concurrently used and having them in overlapped mode wreaks havoc. [link]: https://blogs.msdn.microsoft.com/oldnewthing/20121012-00/?p=6343 Closes rust-lang#38811
nikomatsakis
pushed a commit
to nikomatsakis/rust
that referenced
this pull request
Jan 6, 2017
This commit fixes a mistake introduced in rust-lang#31618 where overlapped handles were leaked to child processes on Windows. On Windows once a handle is in overlapped mode it should always have I/O executed with an instance of `OVERLAPPED`. Most child processes, however, are not prepared to have their stdio handles in overlapped mode as they don't use `OVERLAPPED` on reads/writes to the handle. Now we haven't had any odd behavior in Rust up to this point, and the original bug was introduced almost a year ago. I believe this is because it turns out that if you *don't* pass an `OVERLAPPED` then the system will [supply one for you][link]. In this case everything will go awry if you concurrently operate on the handle. In Rust, however, the stdio handles are always locked, and there's no way to not use them unlocked in libstd. Due to that change we've always had synchronized access to these handles, which means that Rust programs typically "just work". Conversely, though, this commit fixes the test case included, which exhibits behavior that other programs Rust spawns may attempt to execute. Namely, the stdio handles may be concurrently used and having them in overlapped mode wreaks havoc. [link]: https://blogs.msdn.microsoft.com/oldnewthing/20121012-00/?p=6343 Closes rust-lang#38811
bors
added a commit
that referenced
this pull request
Jan 6, 2017
std: Don't pass overlapped handles to processes This commit fixes a mistake introduced in #31618 where overlapped handles were leaked to child processes on Windows. On Windows once a handle is in overlapped mode it should always have I/O executed with an instance of `OVERLAPPED`. Most child processes, however, are not prepared to have their stdio handles in overlapped mode as they don't use `OVERLAPPED` on reads/writes to the handle. Now we haven't had any odd behavior in Rust up to this point, and the original bug was introduced almost a year ago. I believe this is because it turns out that if you *don't* pass an `OVERLAPPED` then the system will [supply one for you][link]. In this case everything will go awry if you concurrently operate on the handle. In Rust, however, the stdio handles are always locked, and there's no way to not use them unlocked in libstd. Due to that change we've always had synchronized access to these handles, which means that Rust programs typically "just work". Conversely, though, this commit fixes the test case included, which exhibits behavior that other programs Rust spawns may attempt to execute. Namely, the stdio handles may be concurrently used and having them in overlapped mode wreaks havoc. [link]: https://blogs.msdn.microsoft.com/oldnewthing/20121012-00/?p=6343 Closes #38811
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read_to_endgets directed towardsread_to_end_uninitializedfor all handleswait_with_output, don't spawn threads to read out the pipes of the child. Instead drain all pipes on the calling thread and then wait on the process.Functionally, it is intended that nothing changes as part of this PR
Note that this was the same as #31613, and even after that it turned out that fixing Windows was easier than I thought! To copy a comment from over there: