Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove wrong assert in check_match #32041

Merged
merged 1 commit into from
Mar 6, 2016
Merged

remove wrong assert in check_match #32041

merged 1 commit into from
Mar 6, 2016

Conversation

arielb1
Copy link
Contributor

@arielb1 arielb1 commented Mar 4, 2016

the assert was invalidated by PR #31020

Fixes #31561

r? @eddyb

@eddyb
Copy link
Member

eddyb commented Mar 4, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Mar 4, 2016

📌 Commit 26a0afb has been approved by eddyb

@nagisa
Copy link
Member

nagisa commented Mar 4, 2016

Should we also nominate this for beta because this fixes a regression from stable to now-beta?

@nagisa nagisa added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 4, 2016
@bors
Copy link
Contributor

bors commented Mar 6, 2016

⌛ Testing commit 26a0afb with merge 80922a7...

bors added a commit that referenced this pull request Mar 6, 2016
@bors
Auto merge of #32041 - arielb1:multiply-inexhaustive, r=eddyb
80922a7 
the assert was invalidated by PR #31020

Fixes #31561

r? @eddyb
@bors
Copy link
Contributor

bors commented Mar 6, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit 26a0afb into rust-lang:master Mar 6, 2016
@nikomatsakis nikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Mar 10, 2016
@alexcrichton alexcrichton mentioned this pull request Mar 16, 2016
Merged
@brson brson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@arielb1 @eddyb @bors @nagisa @brson @nikomatsakis