Allow custom filenames for anonymous inputs #32169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think doctests are a problem here because we call the compiler in slightly weird ways (and don't map the source correctly), but in any case r? @nrc |
| Str(String) | ||
| Str { | ||
| input: String, | ||
| file: String, |
There was a problem hiding this comment.
These need better names or a more detailed comment
|
lgtm, just needs the naming/documentation improved a bit |
|
(updated) Does this look better? |
|
@bors: r+ |
|
📌 Commit ea7cf90 has been approved by |
bors
added a commit
that referenced
this pull request
Mar 14, 2016
Allow custom filenames for anonymous inputs This came out of #29253 but doesn't fix it. I thought it might be worth merging on its own nonetheless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came out of #29253 but doesn't fix it.
I thought it might be worth merging on its own nonetheless.