Fix libstd on DragonFly #32687
Merged
Fix libstd on DragonFly #32687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
| libc::clock_gettime(clock as libc::c_ulong, &mut t.t) | ||
| }).unwrap(); | ||
| t | ||
| } |
There was a problem hiding this comment.
Could the duplication here be reduced from the whole function to just perhaps a typedef?
There was a problem hiding this comment.
Either that or the now here could take an argument of the appropriate type
There was a problem hiding this comment.
Ideally we would export the type as clock_t from libc, then we could just use it here. But I think in this case a typedef is just fine!
Following changes: * birthtime does not exist on DragonFly * errno: __dfly_error is no more. Use #[thread_local] static errno. * clock_gettime expects a c_ulong (use a type alias) These changes are required to build DragonFly snapshots again.
|
@aturon @alexcrichton I rebased and squashed into a single commit. for some unknown reason the travis build shows a failed state (it successfully ran the tests). |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Apr 7, 2016
…excrichton Fix libstd on DragonFly Following changes: * birthtime does not exist on DragonFly * errno: __dfly_error is no more. Use #[thread_local] static errno. * clock_gettime expects a c_ulong These changes are required to build DragonFly snapshots again.
bors
added a commit
that referenced
this pull request
Apr 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following changes:
These changes are required to build DragonFly snapshots again.