Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustbuild: Add support for compiletest test suites #32755

Merged
merged 1 commit into from
Apr 19, 2016
Merged

rustbuild: Add support for compiletest test suites #32755

merged 1 commit into from
Apr 19, 2016

Conversation

alexcrichton
Copy link
Member

This commit adds support in rustbuild for running all of the compiletest test
suites as part of make check. The compiletest program was moved to
src/tools (like rustbook and others) and is now just compiled like any other
old tool. Each test suite has a pretty standard set of dependencies and just
tweaks various parameters to the final compiletest executable.

Note that full support is lacking in terms of:

  • Once a test suite has passed, that's not remembered. When a test suite is
    requested to be run, it's always run.
  • The arguments to compiletest probably don't work for every possible
    combination of platforms and testing environments just yet. There will likely
    need to be future updates to tweak various pieces here and there.
  • Cross compiled test suites probably don't work just yet, support for that will
    come in a follow-up patch.

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton alexcrichton mentioned this pull request Apr 5, 2016
Closed
48 tasks
@alexcrichton alexcrichton force-pushed the rustbuild-start-test branch from 2a529e0 to f964407 Compare April 5, 2016 22:41
@bors
Copy link
Contributor

bors commented Apr 6, 2016

☔ The latest upstream changes (presumably #32767) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton alexcrichton force-pushed the rustbuild-start-test branch from f964407 to 4bb22a5 Compare April 6, 2016 17:14
@brson
Copy link
Contributor

brson commented Apr 7, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Apr 7, 2016

📌 Commit 4bb22a5 has been approved by brson

@bors
Copy link
Contributor

bors commented Apr 7, 2016

☔ The latest upstream changes (presumably #32016) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton alexcrichton force-pushed the rustbuild-start-test branch 2 times, most recently from d766524 to e45739d Compare April 8, 2016 00:09
@alexcrichton
Copy link
Member Author

@bors: r=brson e45739d095137075ee194b9a241b94e49f9c0182

@bors
Copy link
Contributor

bors commented Apr 9, 2016

☔ The latest upstream changes (presumably #32751) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton alexcrichton force-pushed the rustbuild-start-test branch from e45739d to b54aedf Compare April 11, 2016 15:35
@alexcrichton
Copy link
Member Author

@bors: r=brson

@bors
Copy link
Contributor

bors commented Apr 11, 2016

📌 Commit b54aedf has been approved by brson

@bors
Copy link
Contributor

bors commented Apr 12, 2016

⌛ Testing commit b54aedf with merge f836e04...

@bors
Copy link
Contributor

bors commented Apr 12, 2016

💔 Test failed - auto-linux-64-x-android-t

@bors
Copy link
Contributor

bors commented Apr 12, 2016

☔ The latest upstream changes (presumably #32804) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton alexcrichton force-pushed the rustbuild-start-test branch from b54aedf to 808116f Compare April 12, 2016 16:23
@alexcrichton
Copy link
Member Author

@bors: r=brson 808116f

@bors
Copy link
Contributor

bors commented Apr 12, 2016

⌛ Testing commit 808116f with merge 3147de8...

bors added a commit that referenced this pull request Apr 12, 2016
@bors
Auto merge of #32755 - alexcrichton:rustbuild-start-test, r=brson
3147de8 
rustbuild: Add support for compiletest test suites

This commit adds support in rustbuild for running all of the compiletest test
suites as part of `make check`. The `compiletest` program was moved to
`src/tools` (like `rustbook` and others) and is now just compiled like any other
old tool. Each test suite has a pretty standard set of dependencies and just
tweaks various parameters to the final compiletest executable.

Note that full support is lacking in terms of:

* Once a test suite has passed, that's not remembered. When a test suite is
  requested to be run, it's always run.
* The arguments to compiletest probably don't work for every possible
  combination of platforms and testing environments just yet. There will likely
  need to be future updates to tweak various pieces here and there.
* Cross compiled test suites probably don't work just yet, support for that will
  come in a follow-up patch.
@bors
Copy link
Contributor

bors commented Apr 12, 2016

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@bors
Copy link
Contributor

bors commented Apr 13, 2016

☔ The latest upstream changes (presumably #32590) made this pull request unmergeable. Please resolve the merge conflicts.

@retep998
Copy link
Member

3221225781 → 0xC0000135 → STATUS_DLL_NOT_FOUND

@alexcrichton alexcrichton force-pushed the rustbuild-start-test branch 2 times, most recently from f6027db to 9860b73 Compare April 13, 2016 17:06
@alexcrichton
Copy link
Member Author

@bors: r=brson 9860b73

@alexcrichton
Copy link
Member Author

@bors: r=brson 2df14df

@alexcrichton
Copy link
Member Author

@retep998 if you take a look at the logs you'll notice that one of the tests caused compiletest to overflow the stack (don't worry, I can also read test logs).

So what's happening here is a // should-fail test, specifically meta-expected-error-wrong-rev, is indeed panicking (as it should fail). During this panic we're running SEH handlers, but one of them manages to cause a segfault. This in turns runs the SEH handlers, which in turn causes a segfault. Eventually we run out of stack and something dies even harder, causing the binary to crash.

The most terrifying part, however, is that a -C opt-level=2 compiletest doesn't exhibit this behavior, only a -C opt-level=3 one. Taking down the opt-level a bit and praying it works. Investigating this and reporting a but will... take awhile.

@bors
Copy link
Contributor

bors commented Apr 18, 2016

⌛ Testing commit 2df14df with merge 48cf2cb...

@bors
Copy link
Contributor

bors commented Apr 18, 2016

💔 Test failed - auto-win-msvc-64-opt-rustbuild

@alexcrichton alexcrichton force-pushed the rustbuild-start-test branch from 2df14df to 0fca16d Compare April 18, 2016 15:58
@alexcrichton
Copy link
Member Author

Score another one for too-long-paths on Windows.

@alexcrichton
Copy link
Member Author

@bors: r=brson 0fca16d

@bors
Copy link
Contributor

bors commented Apr 18, 2016

☔ The latest upstream changes (presumably #33042) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton alexcrichton force-pushed the rustbuild-start-test branch from 0fca16d to 27b0101 Compare April 18, 2016 19:36
@alexcrichton
Copy link
Member Author

@bors: r=brson 27b0101

@bors
Copy link
Contributor

bors commented Apr 18, 2016

⌛ Testing commit 27b0101 with merge 5221e22...

@bors
Copy link
Contributor

bors commented Apr 18, 2016

💔 Test failed - auto-win-msvc-64-opt-rustbuild

@alexcrichton alexcrichton force-pushed the rustbuild-start-test branch from 27b0101 to 1e96856 Compare April 18, 2016 23:18
@alexcrichton
Copy link
Member Author

@bors: r=brson 1e96856

@alexcrichton
rustbuild: Add support for compiletest test suites
b325baf 
This commit adds support in rustbuild for running all of the compiletest test
suites as part of `make check`. The `compiletest` program was moved to
`src/tools` (like `rustbook` and others) and is now just compiled like any other
old tool. Each test suite has a pretty standard set of dependencies and just
tweaks various parameters to the final compiletest executable.

Note that full support is lacking in terms of:

* Once a test suite has passed, that's not remembered. When a test suite is
  requested to be run, it's always run.
* The arguments to compiletest probably don't work for every possible
  combination of platforms and testing environments just yet. There will likely
  need to be future updates to tweak various pieces here and there.
* Cross compiled test suites probably don't work just yet, support for that will
  come in a follow-up patch.
@alexcrichton alexcrichton force-pushed the rustbuild-start-test branch from 1e96856 to b325baf Compare April 18, 2016 23:30
@alexcrichton
Copy link
Member Author

@bors: r=brson b325baf

@bors
Copy link
Contributor

bors commented Apr 19, 2016

⌛ Testing commit b325baf with merge d36ad55...

bors added a commit that referenced this pull request Apr 19, 2016
@bors
Auto merge of #32755 - alexcrichton:rustbuild-start-test, r=brson
d36ad55 
rustbuild: Add support for compiletest test suites

This commit adds support in rustbuild for running all of the compiletest test
suites as part of `make check`. The `compiletest` program was moved to
`src/tools` (like `rustbook` and others) and is now just compiled like any other
old tool. Each test suite has a pretty standard set of dependencies and just
tweaks various parameters to the final compiletest executable.

Note that full support is lacking in terms of:

* Once a test suite has passed, that's not remembered. When a test suite is
  requested to be run, it's always run.
* The arguments to compiletest probably don't work for every possible
  combination of platforms and testing environments just yet. There will likely
  need to be future updates to tweak various pieces here and there.
* Cross compiled test suites probably don't work just yet, support for that will
  come in a follow-up patch.
@bors
Copy link
Contributor

bors commented Apr 19, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-64-x-armhf, auto-linux-64-x-armsf, auto-linux-64-x-freebsd, auto-linux-64-x-netbsd, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-cross-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild

@bors bors merged commit b325baf into rust-lang:master Apr 19, 2016
This was referenced Apr 19, 2016
Merged
Merged
Merged
Merged
@retep998 retep998 mentioned this pull request Apr 20, 2016
Merged
@alexcrichton alexcrichton deleted the rustbuild-start-test branch May 2, 2016 17:08
@alexcrichton alexcrichton mentioned this pull request May 2, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexcrichton @rust-highfive @bors @brson @retep998