-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustbuild: Add support for compiletest test suites #32755
Conversation
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
2a529e0
to
f964407
Compare
☔ The latest upstream changes (presumably #32767) made this pull request unmergeable. Please resolve the merge conflicts. |
f964407
to
4bb22a5
Compare
@bors r+ |
📌 Commit 4bb22a5 has been approved by |
☔ The latest upstream changes (presumably #32016) made this pull request unmergeable. Please resolve the merge conflicts. |
d766524
to
e45739d
Compare
@bors: r=brson e45739d095137075ee194b9a241b94e49f9c0182 |
☔ The latest upstream changes (presumably #32751) made this pull request unmergeable. Please resolve the merge conflicts. |
e45739d
to
b54aedf
Compare
@bors: r=brson |
📌 Commit b54aedf has been approved by |
⌛ Testing commit b54aedf with merge f836e04... |
💔 Test failed - auto-linux-64-x-android-t |
☔ The latest upstream changes (presumably #32804) made this pull request unmergeable. Please resolve the merge conflicts. |
b54aedf
to
808116f
Compare
rustbuild: Add support for compiletest test suites This commit adds support in rustbuild for running all of the compiletest test suites as part of `make check`. The `compiletest` program was moved to `src/tools` (like `rustbook` and others) and is now just compiled like any other old tool. Each test suite has a pretty standard set of dependencies and just tweaks various parameters to the final compiletest executable. Note that full support is lacking in terms of: * Once a test suite has passed, that's not remembered. When a test suite is requested to be run, it's always run. * The arguments to compiletest probably don't work for every possible combination of platforms and testing environments just yet. There will likely need to be future updates to tweak various pieces here and there. * Cross compiled test suites probably don't work just yet, support for that will come in a follow-up patch.
💔 Test failed - auto-win-gnu-32-opt-rustbuild |
☔ The latest upstream changes (presumably #32590) made this pull request unmergeable. Please resolve the merge conflicts. |
|
f6027db
to
9860b73
Compare
@bors: r=brson 9860b73 |
@bors: r=brson 2df14df |
@retep998 if you take a look at the logs you'll notice that one of the tests caused compiletest to overflow the stack (don't worry, I can also read test logs). So what's happening here is a The most terrifying part, however, is that a |
⌛ Testing commit 2df14df with merge 48cf2cb... |
💔 Test failed - auto-win-msvc-64-opt-rustbuild |
2df14df
to
0fca16d
Compare
Score another one for too-long-paths on Windows. |
@bors: r=brson 0fca16d |
☔ The latest upstream changes (presumably #33042) made this pull request unmergeable. Please resolve the merge conflicts. |
0fca16d
to
27b0101
Compare
@bors: r=brson 27b0101 |
⌛ Testing commit 27b0101 with merge 5221e22... |
💔 Test failed - auto-win-msvc-64-opt-rustbuild |
27b0101
to
1e96856
Compare
@bors: r=brson 1e96856 |
This commit adds support in rustbuild for running all of the compiletest test suites as part of `make check`. The `compiletest` program was moved to `src/tools` (like `rustbook` and others) and is now just compiled like any other old tool. Each test suite has a pretty standard set of dependencies and just tweaks various parameters to the final compiletest executable. Note that full support is lacking in terms of: * Once a test suite has passed, that's not remembered. When a test suite is requested to be run, it's always run. * The arguments to compiletest probably don't work for every possible combination of platforms and testing environments just yet. There will likely need to be future updates to tweak various pieces here and there. * Cross compiled test suites probably don't work just yet, support for that will come in a follow-up patch.
1e96856
to
b325baf
Compare
rustbuild: Add support for compiletest test suites This commit adds support in rustbuild for running all of the compiletest test suites as part of `make check`. The `compiletest` program was moved to `src/tools` (like `rustbook` and others) and is now just compiled like any other old tool. Each test suite has a pretty standard set of dependencies and just tweaks various parameters to the final compiletest executable. Note that full support is lacking in terms of: * Once a test suite has passed, that's not remembered. When a test suite is requested to be run, it's always run. * The arguments to compiletest probably don't work for every possible combination of platforms and testing environments just yet. There will likely need to be future updates to tweak various pieces here and there. * Cross compiled test suites probably don't work just yet, support for that will come in a follow-up patch.
This commit adds support in rustbuild for running all of the compiletest test
suites as part of
make check
. Thecompiletest
program was moved tosrc/tools
(likerustbook
and others) and is now just compiled like any otherold tool. Each test suite has a pretty standard set of dependencies and just
tweaks various parameters to the final compiletest executable.
Note that full support is lacking in terms of:
requested to be run, it's always run.
combination of platforms and testing environments just yet. There will likely
need to be future updates to tweak various pieces here and there.
come in a follow-up patch.