resolve: Avoid emitting redundant path resolution errors #32789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,8 +15,7 @@ fn main() { | |||
| enum Stuff { | |||
| Bar = foo | |||
| //~^ ERROR attempt to use a non-constant value in a constant | |||
| //~| ERROR unresolved name `foo` | |||
| //~^^^ ERROR constant evaluation error: non-constant path in constant expression | |||
| //~^^ ERROR constant evaluation error: non-constant path in constant expression | |||
There was a problem hiding this comment.
Is the const evaluation error triggering for DefError? Could we suppress that, too?
There was a problem hiding this comment.
I believe so -- I'll look into it.
|
r=me with tidy errors fixed. |
|
📌 Commit d3affc6 has been approved by |
jseyfried
force-pushed
the
fix_duplicate_resolve_errors
branch
from
d3affc6 to
07dac97
Compare
|
@bors r=eddyb |
|
📌 Commit 07dac97 has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Apr 7, 2016
…ors, r=eddyb resolve: Avoid emitting redundant path resolution errors This PR avoids emitting redundant path resolution errors in `resolve` (fixes rust-lang#32760). r? @eddyb
bors
added a commit
that referenced
this pull request
Apr 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids emitting redundant path resolution errors in
resolve(fixes #32760).r? @eddyb