-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix str::split_at_mut() example #32941
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gankro (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Showing what's different with the Don't you agree @alexcrichton? |
Sure! |
fix str::split_at_mut() example fix documentation issue rust-lang#32933
Arf, I guess it's too late to r- the PR... |
@GuillaumeGomez, well actually I want to create a different example using asciiExt trait but according to https://doc.rust-lang.org/std/ascii/trait.AsciiExt.html#tymethod.make_ascii_uppercase, fn main() {
use std::ascii::AsciiExt;
let mut s = "Per Martin-Löf".to_string();
{
let (first, last) = s.split_at_mut(3);
first.make_ascii_uppercase();
last.make_ascii_lowercase();
assert_eq!("PER", first);
assert_eq!(" martin-löf", last);
}
assert_eq!("PER martin-löf", s)
} |
Since you're writing examples displayed only on nightly for the moment, it doesn't matter. :p |
fix documentation issue #32933