collections: add append for binary heap

[xosmig]

No description provided.

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[GuillaumeGomez]

I guess it'll be since = 1.10.0 now the 1.8.0 has been released.

[xosmig]

@GuillaumeGomez, Ok, I will fix it. I didn't find any strict rules for this line.

[GuillaumeGomez]

it's the current release version + 2 (since there is beta between them).

[apasel422]

@xosmig This looks great! Would it be possible to also add a specialization for Extend like the one in #32851?

[alexcrichton]

Looks like the append doctest may not be working?

---- binary_heap::BinaryHeap<T>::append_0 stdout ----
    <anon>:5:17: 5:33 error: failed to resolve. Use of undeclared type or module `BinaryHeap` [E0433]
<anon>:5     let mut a = BinaryHeap::from(v);
                         ^~~~~~~~~~~~~~~~
<anon>:8:17: 8:33 error: failed to resolve. Use of undeclared type or module `BinaryHeap` [E0433]
<anon>:8     let mut b = BinaryHeap::from(v);
                         ^~~~~~~~~~~~~~~~
<anon>:10:5: 10:21 error: the type of this value must be known in this context
<anon>:10     a.append(&mut b);
              ^~~~~~~~~~~~~~~~
<std macros>:5:8: 5:18 error: the type of this value must be known in this context
<std macros>:5 if ! ( * left_val == * right_val ) {
                      ^~~~~~~~~~
<anon>:12:5: 12:68 note: in this expansion of assert_eq! (defined in <std macros>)
<std macros>:5:22: 5:33 error: the type of this value must be known in this context
<std macros>:5 if ! ( * left_val == * right_val ) {
                                    ^~~~~~~~~~~
<anon>:12:5: 12:68 note: in this expansion of assert_eq! (defined in <std macros>)
<anon>:13:13: 13:25 error: the type of this value must be known in this context
<anon>:13     assert!(b.is_empty());
                      ^~~~~~~~~~~~
<anon>:13:5: 13:27 note: in this expansion of assert! (defined in <std macros>)
error: aborting due to previous error(s)
thread 'binary_heap::BinaryHeap<T>::append_0' panicked at 'Box<Any>', src/librustc/session/mod.rs:161
note: Run with `RUST_BACKTRACE=1` for a backtrace.


failures:
    binary_heap::BinaryHeap<T>::append_0

@bors: delegate=apasel422

[bors]

✌️ @apasel422 can now approve this pull request

[alexcrichton]

Could this start out as #[unstable] actually? It should be easily stabilized as it fits conventions but we try to avoid insta-stable methods wherever possible.

[xosmig]

@alexcrichton Should I create a new issue for stabilization of it?

[apasel422]

@xosmig You can use #32526 as the issue and remove "Closes #32526" from the PR description.

[xosmig]

@apasel422 may be #28147 is more suitable? Can I use it?

[apasel422]

@xosmig I don't think so. append already meets conventions, while push_pop and replace do not, so it is more likely for this new method to be stabilized as is.

[alexcrichton]

Yeah #32526 seems good

[apasel422]

@xosmig Could you squash these commits? This looks ready to go otherwise.

[xosmig]

@apasel422 Should I squash all three commits into one?

[apasel422]

@xosmig Yes, thanks!

[apasel422]

@bors: r+ faeba73

[bors]

⌛ Testing commit faeba73 with merge d8d7174...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-64-x-armhf, auto-linux-64-x-armsf, auto-linux-64-x-freebsd, auto-linux-64-x-netbsd, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-cross-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild