-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement negation for wrapping numerals. #33067
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Impls are insta-stable, stability attributes have no effect on them |
Thanks for the PR @notriddle! As @jonas-schievink mentioned we unfortunately don't read stability annotations on I'll tag this with T-libs as well to be sure it comes up during triage. |
af4efb1
to
9cb4d1b
Compare
The libs team discussed this during triage today and the decision was to merge. Thanks again for the PR @notriddle! |
Implement negation for wrapping numerals. Fixes #33037
💔 Test failed - auto-win-msvc-64-cargotest |
can has RUST_BACKTRACE plz? @bors retry |
I've opened up rust-lang/cargo#2650, and I've seen this issue quite a few times on Cargo itself unfortunately. I haven't been able to reproduce locally yet, though, to debug. |
Fixes #33037