Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement find() on Chain iterators #33289

Merged
merged 1 commit into from
May 2, 2016
Merged

Conversation

birkenfeld
Copy link
Contributor

This results in a roughly 2x speedup compared to the default impl
"inherited" from Iterator.

Benchmark: https://gist.github.com/birkenfeld/aa9b92cb7d55666dd4821207527eaf5b

This results in a roughly 2x speedup compared to the default impl
"inherited" from Iterator.
@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@bluss
Copy link
Member

bluss commented May 1, 2016

@bors r+

Thanks, this looks good!

@bors
Copy link
Contributor

bors commented May 1, 2016

📌 Commit e6201cf has been approved by bluss

@bors
Copy link
Contributor

bors commented May 1, 2016

⌛ Testing commit e6201cf with merge ccbc3a6...

bors added a commit that referenced this pull request May 1, 2016
Implement find() on Chain iterators

This results in a roughly 2x speedup compared to the default impl
"inherited" from Iterator.

Benchmark: https://gist.github.com/birkenfeld/aa9b92cb7d55666dd4821207527eaf5b
@bors
Copy link
Contributor

bors commented May 1, 2016

💔 Test failed - auto-linux-musl-64-opt

@bluss
Copy link
Member

bluss commented May 1, 2016

failures:

---- [codegen-units] codegen-units/partitioning/local-transitive-inlining.rs stdout ----

error: compilation failed!
status: exit code: 101
command: x86_64-unknown-linux-gnu/stage2/bin/rustc /buildslave/rust-buildbot/slave/auto-linux-musl-64-opt/build/src/test/codegen-units/partitioning/local-transitive-inlining.rs -L x86_64-unknown-linux-gnu/test/codegen-units/ --target=x86_64-unknown-linux-musl -L x86_64-unknown-linux-gnu/test/codegen-units/partitioning/local-transitive-inlining.stage2-x86_64-unknown-linux-musl.codegen-units.libaux -C prefer-dynamic -o x86_64-unknown-linux-gnu/test/codegen-units/partitioning/local-transitive-inlining.stage2-x86_64-unknown-linux-musl -C linker=/musl-x86_64/bin/musl-gcc -C ar=ar --cfg rtopt -C rpath -O -L x86_64-unknown-linux-musl/rt -Zprint-trans-items=lazy -Zincremental=tmp
stdout:
------------------------------------------
TRANS_ITEM fn local_transitive_inlining::direct_user[0]::foo[0] @@ local_transitive_inlining-direct_user[WeakODR] local_transitive_inlining-indirect_user[Available]
TRANS_ITEM fn local_transitive_inlining::indirect_user[0]::bar[0] @@ local_transitive_inlining-indirect_user[WeakODR]
TRANS_ITEM fn local_transitive_inlining::inline[0]::inlined_function[0] @@ local_transitive_inlining-direct_user[Available] local_transitive_inlining-indirect_user[Available] local_transitive_inlining-inline[WeakODR]
TRANS_ITEM fn local_transitive_inlining::non_user[0]::baz[0] @@ local_transitive_inlining-non_user[WeakODR]

------------------------------------------
stderr:
------------------------------------------
error: unable to delete old dep-graph at `tmp/dep_graph.rbml`: No such file or directory (os error 2)
error: aborting due to previous error

------------------------------------------

thread '[codegen-units] codegen-units/partitioning/local-transitive-inlining.rs' panicked at 'explicit panic', /buildslave/rust-buildbot/slave/auto-linux-musl-64-opt/build/src/tools/compiletest/src/runtest.rs:1595
note: Run with `RUST_BACKTRACE=1` for a backtrace.

from the buildbot. Some kind of error unrelated to the PR.

@birkenfeld
Copy link
Contributor Author

@bluss see #33315

@alexcrichton
Copy link
Member

@bors: retry

@bors
Copy link
Contributor

bors commented May 2, 2016

⌛ Testing commit e6201cf with merge e1a575c...

bors added a commit that referenced this pull request May 2, 2016
Implement find() on Chain iterators

This results in a roughly 2x speedup compared to the default impl
"inherited" from Iterator.

Benchmark: https://gist.github.com/birkenfeld/aa9b92cb7d55666dd4821207527eaf5b
@bors bors merged commit e6201cf into rust-lang:master May 2, 2016
@birkenfeld birkenfeld deleted the chain-find branch May 3, 2016 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants