-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adt: Allow repr attribute on single variant enum. #33355
Conversation
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
Why can't we let cc @rust-lang/lang |
Nominating for discussion at the next meeting, if we don't reach consensus before then. |
☔ The latest upstream changes (presumably #33425) made this pull request unmergeable. Please resolve the merge conflicts. |
9c47062
to
a08c398
Compare
Discussed in @rust-lang/lang meeting. I think we all agree it seems like permitting this annotation might be nice, but if it's awkward to implement, than an error is fine too. @luqmana what say you? |
@nikomatsakis Ok, I made it an error because there was an asset in trans to that effect. I can change it to allow this. |
Ok, updated |
@bors: r+ |
📌 Commit f3e1d57 has been approved by |
adt: Allow repr attribute on single variant enum. Fixes #33202.
Fixes #33202.