Bitv Constructors #3351
Closed
Bitv Constructors #3351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. from_bytes, from_bools and from_fn were not exported but should have been. 2. lots of stuff that either didnt exist or didnt need exporting was being exported.
…ed methods syntax. Also standardise the comment indentation and add some whitespace between items.
|
Merged. |
|
Thanks! Sorry about the commits from other people that got into my branch On 4 September 2012 21:28, Brian Anderson notifications@github.com wrote:
|
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Mar 9, 2024
…armful, r=RalfJung disable diagnostic deduplication `@oli-obk` is there a better way to do this? Ideally we'd only set this when interpretation starts but the value in the compiler session seems to be immutable. I assume people will do `cargo check` before `cargo miri` so hopefully this won't lead to too much confusion. Fixes rust-lang/miri#3350
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds new bitv constructors as proposed in issue #2964. I also attempted to update the bitv module to more current rust.