Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline RawVec::cap #33522

Merged
merged 1 commit into from
May 11, 2016
Merged

Inline RawVec::cap #33522

merged 1 commit into from
May 11, 2016

Conversation

mbrubeck
Copy link
Contributor

@mbrubeck mbrubeck commented May 9, 2016 •
edited
Loading

This was showing up in a Servo profile.

@mbrubeck mbrubeck force-pushed the inline-rawvec-cap branch from 3144064 to 06f5fa4 Compare May 9, 2016 18:45
@mbrubeck
Copy link
Contributor Author

mbrubeck commented May 9, 2016

Per discussion on #33357, this function is generic and therefore already inlineable. It was probably not inlined because Servo's build system sets codegen-units > 1 by default. Due to #32469 this can inhibit inlining of functions that are generic but not #[inline].

@nagisa
Copy link
Member

nagisa commented May 9, 2016

@bors r+

@bors
Copy link
Contributor

bors commented May 9, 2016

📌 Commit 06f5fa4 has been approved by nagisa

@pcwalton pcwalton mentioned this pull request May 9, 2016
Closed
@eddyb
Copy link
Member

eddyb commented May 11, 2016

@bors rollup

steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 11, 2016
@steveklabnik
Rollup merge of rust-lang#33522 - mbrubeck:inline-rawvec-cap, r=nagisa
30df9d0 
Inline RawVec::cap

This was showing up in a Servo profile.
@steveklabnik steveklabnik mentioned this pull request May 11, 2016
Merged
bors added a commit that referenced this pull request May 11, 2016
@bors
Auto merge of #33556 - steveklabnik:rollup, r=steveklabnik
e37f859 
Rollup of 9 pull requests

- Successful merges: #33129, #33260, #33345, #33386, #33522, #33524, #33528, #33539, #33542
- Failed merges: #33342, #33475, #33517
@bors bors merged commit 06f5fa4 into rust-lang:master May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mbrubeck @nagisa @bors @eddyb