Rollup of 3 pull requests #33562
Merged
Rollup of 3 pull requests #33562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GuillaumeGomez
commented
May 11, 2016
GuillaumeGomez
commented
- Successful merges: Add rustc_on_unimplemented for Index implementation on slice #33401, Improve help for make command #33489, trivial tweaks to documentation (book) #33558
- Failed merges: typeck: if a private field exists, also check for a public method #33342, Add detailed error explanation for E0505 #33475, Tighten span for E0063 #33517
Add examples for "make help" command
…mpl, this message will be displayed instead
Add more comments for the global understanding
…pnkfelix Add rustc_on_unimplemented for Index implementation on slice Reopening of rust-lang#31071. It also extends the possibility of `#[rustc_on_unimplemented]` by providing a small type filter in order to find the ones which corresponds the most. r? @pnkfelix
Improve help for make command r? @steveklabnik
…veklabnik trivial tweaks to documentation (book) These are small things I found while reading through The Book. The `<hash>` and `panic!` lines are simply to improve readability, while I believe the proceeding/following distinction is a bug (but might be a English dialect distinction?). I've read `rust/CONTRIBUTING`, i'm not sure if there is anything I need to do other than submit this PR. r? @steveklabnik
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=1 |
|
📌 Commit 10f9f30 has been approved by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.