Export OnceState from libstd #33563
Merged
Export OnceState from libstd #33563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,7 +31,7 @@ pub use self::mutex::MUTEX_INIT; | |||
| #[stable(feature = "rust1", since = "1.0.0")] | |||
| pub use self::mutex::{Mutex, MutexGuard, StaticMutex}; | |||
| #[stable(feature = "rust1", since = "1.0.0")] | |||
| pub use self::once::{Once, ONCE_INIT}; | |||
| pub use self::once::{Once, OnceState, ONCE_INIT}; | |||
There was a problem hiding this comment.
OnceState itself is unstable. But this reexport is marked stable. How do those interact?
There was a problem hiding this comment.
The stability of the actual item is used, not the re-export. See StaticMutex for example, which is currently unstable as well.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 12, 2016
Export OnceState from libstd This type is used in the signature of `call_once_force` but isn't exported from libstd. r? @alexcrichton
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
May 12, 2016
Export OnceState from libstd This type is used in the signature of `call_once_force` but isn't exported from libstd. r? @alexcrichton
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
May 13, 2016
Export OnceState from libstd This type is used in the signature of `call_once_force` but isn't exported from libstd. r? @alexcrichton
bors
added a commit
that referenced
this pull request
May 14, 2016
Export OnceState from libstd This type is used in the signature of `call_once_force` but isn't exported from libstd. r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This type is used in the signature of
call_once_forcebut isn't exported from libstd.r? @alexcrichton