Rollup of 15 pull requests #33629
Closed
Rollup of 15 pull requests #33629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adding name attribute to the sample code - Fix description sentences
For example, `Vec::len` is both a field and a method, and usually encountering `vec.len` just means that the parens were forgotten. Fixes: rust-lang#26472
It isn't "newly introduced" anymore.
Looks more nice, and same is done with prior examples
typeck: if a private field exists, also check for a public method For example, `Vec::len` is both a field and a method, and usually encountering `vec.len` just means that the parens were forgotten. Fixes: rust-lang#26472 NOTE: I added the parameter `allow_private` to `method::exists` since I don't want to suggest inaccessible methods. For the second case, where only the method exists, I think it would make sense to set it to `false` as well, but I wanted to preserve compatibility for this case.
…tion, r=steveklabnik Add error description for E0455 r? @GuillaumeGomez. About this error there is no much thing to explain. The short description says enough to understand. Feel free to review.
Add error explanations for E0374, E0375, E0376 on issue rust-lang#32777
Add detailed error explanation for E0505 Part of rust-lang#32777
Tighten span for E0063
…abnik Add E0500 error explanation r? @Manishearth Part of rust-lang#32777.
Simplify text This way it should be clear: Any number of other threads have this guaranty not just one other thread.
Fix typo in std::sync::Once documentation
Cleanup formatting and wording for `std::env::temp_dir` docs. None
update "reason" for fnbox feature gate It isn't "newly introduced" anymore.
…laumeGomez Use the correct word in the explanation r? @steveklabnik
doc: Fix comment in std::string::String example code
doc: to_string not needed since we gots coercion
doc: line these comments up Looks more nice, and same is done with prior examples
doc: use less awkward and less confusing language
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=1 |
|
📌 Commit 7ba8ec7 has been approved by |
bors
added a commit
that referenced
this pull request
May 14, 2016
|
💔 Test failed - auto-win-gnu-32-opt-rustbuild |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::env::temp_dirdocs. #33580, update "reason" for fnbox feature gate #33590, Use the correct word in the explanation #33591, doc: Fix comment in std::string::String example code #33598, doc: to_string not needed since we gots coercion #33603, doc: line these comments up #33604, doc: use less awkward and less confusing language #33605