Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in macro expression spans #33712

Merged
merged 1 commit into from
May 19, 2016
Merged

Fix bug in macro expression spans #33712

merged 1 commit into from
May 19, 2016

Conversation

jseyfried
Copy link
Contributor

Fix a bug in macro expression spans.
r? @nrc

@jseyfried
Copy link
Contributor Author

jseyfried commented May 18, 2016 •
edited
Loading

The bug was introduced here (that line should have remained span: e.span) and was partially fixed in this commit (specifically, the expn_id field of the span was fixed).

@jseyfried jseyfried mentioned this pull request May 18, 2016
Merged
@nrc
Copy link
Member

nrc commented May 19, 2016

@bors: r+

@bors
Copy link
Contributor

bors commented May 19, 2016

📌 Commit f630419 has been approved by nrc

Manishearth added a commit to Manishearth/rust that referenced this pull request May 19, 2016
@Manishearth
Rollup merge of rust-lang#33712 - jseyfried:fix_expanded_expr_span_bu…
8b4b3a8 
…g, r=nrc

Fix bug in macro expression spans

Fix a bug in macro expression spans.
r? @nrc
@Manishearth Manishearth mentioned this pull request May 19, 2016
Merged
bors added a commit that referenced this pull request May 19, 2016
@bors
Auto merge of #33742 - Manishearth:rollup, r=Manishearth
764ef92 
Rollup of 10 pull requests

- Successful merges: #33353, #33611, #33696, #33698, #33705, #33708, #33712, #33720, #33721, #33730
- Failed merges:
@bors bors merged commit f630419 into rust-lang:master May 19, 2016
@mcarton mcarton mentioned this pull request May 20, 2016
Merged
@jseyfried jseyfried mentioned this pull request May 28, 2016
Closed
@jseyfried jseyfried mentioned this pull request Jul 15, 2016
Closed
@jseyfried jseyfried mentioned this pull request Aug 31, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nrc nrc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jseyfried @nrc @bors