Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify docs for sort(&mut self) #33746

Merged
merged 1 commit into from
May 21, 2016
Merged

Conversation

dns2utf8
Copy link
Contributor

I documented the memory usage like noted in this issue:

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gankro (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@@ -779,11 +779,11 @@ impl<T> [T] {
core_slice::SliceExt::binary_search_by_key(self, b, f)
}

/// Sorts the slice, in place.
///

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra empty line.

@GuillaumeGomez
Copy link
Member

r? @steveklabnik

@steveklabnik
Copy link
Member

I agree that the newline should be removed. The comma is fine, or fine to remove; I would probably write it, but I also know I tend towards using more commas than most people, and it reads fine either way.

@GuillaumeGomez
Copy link
Member

It's just details, but in this case, I think that the comma is slowing down my reading needlessly.

@dns2utf8
Copy link
Contributor Author

Hm, I like the commas, the seperate the sentences so well.

@dns2utf8
Copy link
Contributor Author

Oh, I noticed I use a lot of them myself 😄 Removed them.

@steveklabnik
Copy link
Member

@bors: r+ rollup

Thanks!

@bors
Copy link
Contributor

bors commented May 20, 2016

📌 Commit bf8c070 has been approved by steveklabnik

@dns2utf8
Copy link
Contributor Author

Thank you too!

Manishearth added a commit to Manishearth/rust that referenced this pull request May 21, 2016
…abnik

Clarify docs for sort(&mut self)

I documented the memory usage like noted in this issue:
  * Document memory usage of sort() family of functions rust-lang#33419
bors added a commit that referenced this pull request May 21, 2016
Rollup of 7 pull requests

- Successful merges: #33578, #33679, #33743, #33746, #33747, #33750, #33757
- Failed merges:
@bors bors merged commit bf8c070 into rust-lang:master May 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants